-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenBLAS/lapack] Apply the patch from xianyi/OpenBLAS#3392 #3708
Conversation
@Keno Which version of OpenBLAS should I be applying this patch to? It seems to be "failing to apply the patch" when I try to apply it to OpenBLAS 0.3.10. |
OpenBLAS vendors lapack in one of it's source directories. You'll have to adjust the patch file or patch invocation accordingly. |
571f0cc
to
06644bc
Compare
Alright, I'm now using the patch file from the relevant PR to OpenBLAS (OpenMathLib/OpenBLAS#3392). |
It looks like the patch is applying correctly now. I put it in the three folders corresponding to OpenBLAS version 0.3.10. Is that sufficient, or should I also put it into the folders for other versions of OpenBLAS? |
6513f27
to
4f7277c
Compare
I guess I don't understand how the patch folders work here. If I add the patch file to OpenBLAS 0.3.10, does it automatically get applied to later OpenBLAS versions as well? Or do I manually need to symlink my patch file into the |
Yes, it needs to be symlinked into every |
5ea1875
to
41ec23f
Compare
41ec23f
to
bf73755
Compare
😭 😭 😭 |
Do the HighBlasCount ones in a second PR |
Most likely, we won't need the highcorecounts going forward now that JuliaLang/julia#3667 is merged. |
@vchuravy I disabled auto-merge because they are two CI failures. |
Have we applied this patch to the julia source build too? I believe the next step might be to bump this for master and if everything looks ok, we do the same for 1.6 and 1.7. |
…iaPackaging#3708) * [OpenBLAS/lapack] Apply the patch from OpenMathLib/OpenBLAS#3392 Co-authored-by: Valentin Churavy <[email protected]>
This pull request applies the patch from OpenMathLib/OpenBLAS#3392 to the following JLLs:
Refs JuliaLang/LinearAlgebra.jl#873
Refs Reference-LAPACK/lapack#625