Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenBLAS/lapack] Fix the LinearAlgebra/tridiag segfaults by adding the relevant patch and bumping the OpenBLAS JLLs #42546

Merged
merged 2 commits into from
Oct 9, 2021
Merged

[OpenBLAS/lapack] Fix the LinearAlgebra/tridiag segfaults by adding the relevant patch and bumping the OpenBLAS JLLs #42546

merged 2 commits into from
Oct 9, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Oct 8, 2021 •
edited by vchuravy
Loading

Fixes JuliaLang/LinearAlgebra.jl#873
Refs Reference-LAPACK/lapack#625

Tasks:

@DilumAluthge DilumAluthge added bugfix This change fixes an existing bug ci Continuous integration external dependencies Involves LLVM, OpenBLAS, or other linked libraries linear algebra Linear algebra and removed ci Continuous integration labels Oct 8, 2021
@DilumAluthge DilumAluthge changed the title Fix the LinearAlgebra/tridiag segfaults by adding the relevant patch and bumping the OpenBLAS JLLs [OpenBLAS/lapack] Fix the LinearAlgebra/tridiag segfaults by adding the relevant patch and bumping the OpenBLAS JLLs Oct 8, 2021
@DilumAluthge
[OpenBLAS/lapack] Fix the LinearAlgebra/tridiag segfaults by adding…
6f535fa 
… the relevant patch and bumping the OpenBLAS JLLs
@KristofferC
Copy link
Member

This needs to get backported too I guess. I also see the tridiag failures on the backport branch for 1.7.

@DilumAluthge DilumAluthge added this to the 1.7 milestone Oct 8, 2021
@vchuravy vchuravy marked this pull request as ready for review October 9, 2021 00:52
@DilumAluthge
Copy link
Member Author

This needs to get backported too I guess. I also see the tridiag failures on the backport branch for 1.7.

See #42563 for the 1.7 backport.

@vchuravy vchuravy merged commit a0504ab into master Oct 9, 2021
@vchuravy vchuravy deleted the dpa/tridiag-segfault-42415 branch October 9, 2021 04:04
KristofferC pushed a commit that referenced this pull request Oct 9, 2021
@vchuravy @DilumAluthge
Backport #42546 to 1.7 (#42563)
7014ffb 
* [OpenBLAS/lapack] Fix the `LinearAlgebra/tridiag` segfaults by adding the relevant patch and bumping the OpenBLAS JLLs

(cherry picked from commit 6f535fa)

* bump OpenBLAS_jll

Co-authored-by: Dilum Aluthge <[email protected]>
KristofferC pushed a commit that referenced this pull request Oct 9, 2021
@vchuravy @DilumAluthge
Backport #42546 to 1.6 (#42564)
09eb635 
* [OpenBLAS/lapack] Fix the `LinearAlgebra/tridiag` segfaults by adding the relevant patch and bumping the OpenBLAS JLLs

(cherry picked from commit 6f535fa)

* bump OpenBLAS_jll

Co-authored-by: Dilum Aluthge <[email protected]>
@DilumAluthge DilumAluthge mentioned this pull request Oct 9, 2021
Merged
vchuravy added a commit that referenced this pull request Oct 9, 2021
@vchuravy
Revert "Backport #42546 to 1.6 (#42564)"
1a92e56 
This reverts commit 09eb635.
vchuravy added a commit that referenced this pull request Oct 9, 2021
@vchuravy @DilumAluthge
Backport #42546 to 1.6 (#42564)
cc71755 
* [OpenBLAS/lapack] Fix the `LinearAlgebra/tridiag` segfaults by adding the relevant patch and bumping the OpenBLAS JLLs

(cherry picked from commit 6f535fa)

* bump OpenBLAS_jll

Co-authored-by: Dilum Aluthge <[email protected]>
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
@vchuravy @DilumAluthge @KristofferC
Backport #42546 to 1.6 (#42564)
d3b7f3d 
* [OpenBLAS/lapack] Fix the `LinearAlgebra/tridiag` segfaults by adding the relevant patch and bumping the OpenBLAS JLLs

(cherry picked from commit 6f535fa)

* bump OpenBLAS_jll

Co-authored-by: Dilum Aluthge <[email protected]>
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vchuravy @DilumAluthge @staticfloat
Backport #42546 to 1.6 (#42564)
1305aa6 
* [OpenBLAS/lapack] Fix the `LinearAlgebra/tridiag` segfaults by adding the relevant patch and bumping the OpenBLAS JLLs

(cherry picked from commit 6f535fa)

* bump OpenBLAS_jll

Co-authored-by: Dilum Aluthge <[email protected]>
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vchuravy @staticfloat
Revert "Backport #42546 to 1.6 (#42564)"
ebac0d9 
This reverts commit 09eb635.
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vchuravy @DilumAluthge @staticfloat
Backport #42546 to 1.6 (#42564)
53f3510 
* [OpenBLAS/lapack] Fix the `LinearAlgebra/tridiag` segfaults by adding the relevant patch and bumping the OpenBLAS JLLs

(cherry picked from commit 6f535fa)

* bump OpenBLAS_jll

Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat Awaiting requested review from staticfloat

@vchuravy vchuravy Awaiting requested review from vchuravy

@andreasnoack andreasnoack Awaiting requested review from andreasnoack

@Keno Keno Awaiting requested review from Keno

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug external dependencies Involves LLVM, OpenBLAS, or other linked libraries linear algebra Linear algebra
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

stegr! call segfault
3 participants
@DilumAluthge @KristofferC @vchuravy