Replace inefficient broadcast with copyto!
#438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
commented
Jul 29, 2022
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 82.79% 82.80% +0.01%
==========================================
Files 23 23
Lines 2889 2891 +2
==========================================
+ Hits 2392 2394 +2
Misses 497 497
Continue to review full report at Codecov.
|
Co-authored-by: Daniel Karrasch <[email protected]>
|
Thanks!! Will merge in once all the tests run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in a nanosoldier run in JuliaLang/julia#46196. Independently from that PR, the broadcasting used here previously is super slow in any case, because it computes elementwise
getindexwhich needs to be computed and is not readily readable. The proposed change should speed this step up significantly, at least on Julia v1.7+, see JuliaLang/julia#39533.