Replace inefficient broadcast with copyto! (#438)

* Replace inefficient broadcast with `copyto!` * Update src/polynomials/ngcd.jl Co-authored-by: Daniel Karrasch <[email protected]> Co-authored-by: john verzani <[email protected]>
JuliaMath · Jul 29, 2022 · bf295af · bf295af
1 parent ad781ef
commit bf295af
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/polynomials/ngcd.jl b/src/polynomials/ngcd.jl
@@ -266,7 +266,9 @@ function ngcd(p::PnPolynomial{T,X},
 
     nr, nc = size(Sₓ) # m+1, m-n+2
     F = qr(Sₓ)
-    Q[1:nr, 1:nr] .= F.Q
+    dest = view(Q, 1:nr, 1:nr)
+    copyto!(dest, I)
+    lmul!(F.Q, dest)
     R[1:nc, 1:nc] .= F.R
 
     # tolerances