[WIP] Ring type (issue #349, #234) #350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issue #329 and an earlier -- much more intrusive -- PR #234, this
relaxes
T
inAbstractPolynomial{T,X}
to be any type, not justT <: Number
.The main operations should mostly work, but we use some assumptions on methods for
T
thatget exposed below.
At a minimum, it seems the following should work for this to be useful when T has +,* defined for it:
See the new tests for details.