Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ngcd bug #329

Merged
merged 48 commits into from
Mar 30, 2021
Merged

Ngcd bug #329

merged 48 commits into from
Mar 30, 2021

Conversation

jverzani
Copy link
Member

@jverzani jverzani commented Mar 29, 2021

This started as a small bug fix, but ended up being a rework of the backend of the ngcd code to use a polynomial type instead of vectors. There is a some performance improvement seen in a smaller test case, but no algorithmic changes.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #329 (94eeaad) into master (0bafe29) will increase coverage by 0.65%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   90.20%   90.85%   +0.65%     
==========================================
  Files          15       15              
  Lines        1919     1957      +38     
==========================================
+ Hits         1731     1778      +47     
+ Misses        188      179       -9     
Impacted Files Coverage Δ
src/polynomials/multroot.jl 92.15% <ø> (ø)
src/polynomials/ngcd.jl 90.26% <88.80%> (+3.00%) ⬆️
src/abstract.jl 39.39% <100.00%> (-3.04%) ⬇️
src/common.jl 92.35% <0.00%> (+0.95%) ⬆️
src/polynomials/SparsePolynomial.jl 98.14% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bafe29...94eeaad. Read the comment docs.

@jverzani jverzani merged commit 9d51785 into JuliaMath:master Mar 30, 2021
@jverzani jverzani deleted the ngcd_bug branch March 30, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant