Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the canonical metric on the Stiefel manifold #335
Implement the canonical metric on the Stiefel manifold #335
Changes from 24 commits
03ebd9f
1908eb6
e79a1b5
c993f3b
f36ab3e
edc96c9
e7b914e
3950004
d9008f3
9c61049
0a8aae0
f97f37f
cee6df2
018c288
c89c763
b062c87
50f83ca
ec7f6f3
4d359b5
7103ada
102018b
6a7447a
ce20bfb
94302ca
b13cfb0
9b8e3c4
571776a
456621e
7f99f8d
ca261fd
2b1ebd0
34eba33
d7ce927
0ceb65b
296f107
2a2d8e7
07d8598
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you blockwise multiply here, then instead of the 3 allocations here, I think you can do with none.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would I do that? I twiddled so much with these few lines of code, before and after your allocation reduction (about 2 days to find that we can not use the
svd!
) that I don't see directly how to do this block wise.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a stab at it.