Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the canonical metric on the Stiefel manifold #335

Merged
merged 37 commits into from
Mar 22, 2021
Merged

Implement the canonical metric on the Stiefel manifold #335

merged 37 commits into from
Mar 22, 2021

Commits on Mar 6, 2021

  1. reorganize code and sketch initial algorithms of exp and log for cano… 

    …nical metric on manifolds.
    @kellertuer
    kellertuer committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    03ebd9f View commit details
    Browse the repository at this point in the history

  2. update documentation.

    @kellertuer
    kellertuer committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    1908eb6 View commit details
    Browse the repository at this point in the history

  3. undo a commented our part in docs.

    @kellertuer
    kellertuer committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    e79a1b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Seth Axen <[email protected]>
    @kellertuer @sethaxen
    kellertuer and sethaxen authored Mar 7, 2021
    Configuration menu
    Copy the full SHA
    c993f3b View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Seth Axen <[email protected]>
    @kellertuer @sethaxen
    kellertuer and sethaxen authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    f36ab3e View commit details
    Browse the repository at this point in the history

  2. runs formatter.

    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    edc96c9 View commit details
    Browse the repository at this point in the history

  3. Fix plots (for documentation and testing) to 1.10.5, since it introdu… 

    …ces a bug (see JuliaPlots/Plots.jl#3341) in the next version
    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    e7b914e View commit details
    Browse the repository at this point in the history

  4. Losen constraints for Julia 1.4

    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    3950004 View commit details
    Browse the repository at this point in the history

  5. fix latex equation.

    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    d9008f3 View commit details
    Browse the repository at this point in the history

  6. Fix documentation.

    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    9c61049 View commit details
    Browse the repository at this point in the history

  7. changing compats again, hopefully this works?

    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    0a8aae0 View commit details
    Browse the repository at this point in the history

  8. starts testing.

    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    f97f37f View commit details
    Browse the repository at this point in the history

  9. adopts one view, such that the multiplication is well defined. Finish… 

    …es testing.
    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    cee6df2 View commit details
    Browse the repository at this point in the history

  10. Fix spacing.

    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    018c288 View commit details
    Browse the repository at this point in the history

  11. fixes a few bugs, starts extended testing that includes the iterations.

    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    c89c763 View commit details
    Browse the repository at this point in the history

  12. runs formatter.

    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    b062c87 View commit details
    Browse the repository at this point in the history

  13. removes a little bit of unnecessary lines.

    @kellertuer
    kellertuer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    50f83ca View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Merge branch 'master' into kellertuer/steifel-canonical-metric

    @kellertuer
    kellertuer committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    ec7f6f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. enforce real part of log and avoid svd! to not change V.

    @kellertuer
    kellertuer committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    4d359b5 View commit details
    Browse the repository at this point in the history

  2. Update src/manifolds/StiefelCanonicalMetric.jl 

    Co-authored-by: Mateusz Baran <[email protected]>
    @kellertuer @mateuszbaran
    kellertuer and mateuszbaran authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    7103ada View commit details
    Browse the repository at this point in the history

  3. introduce distance and kwargs for the log, extend tests.

    @kellertuer
    kellertuer committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    102018b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'kellertuer/steifel-canonical-metric' of github.com:Juli… 

    …aManifolds/Manifolds.jl into kellertuer/steifel-canonical-metric
    @kellertuer
    kellertuer committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    6a7447a View commit details
    Browse the repository at this point in the history

  5. remove some debug print and run formatter.

    @kellertuer
    kellertuer committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    ce20bfb View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. improve the test, where an approximation is actually needed.

    @kellertuer
    kellertuer committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    94302ca View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. Update src/manifolds/SymmetricPositiveDefinite.jl 

    Co-authored-by: Seth Axen <[email protected]>
    @kellertuer @sethaxen
    kellertuer and sethaxen authored Mar 21, 2021
    Configuration menu
    Copy the full SHA
    b13cfb0 View commit details
    Browse the repository at this point in the history

  2. address points from code review.

    @kellertuer
    kellertuer committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    9b8e3c4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'kellertuer/steifel-canonical-metric' of github.com:Juli… 

    …aManifolds/Manifolds.jl into kellertuer/steifel-canonical-metric
    @kellertuer
    kellertuer committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    571776a View commit details
    Browse the repository at this point in the history

  4. Adress points from code review.

    @kellertuer
    kellertuer committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    456621e View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Merge branch 'master' into kellertuer/steifel-canonical-metric

    @sethaxen
    sethaxen committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    7f99f8d View commit details
    Browse the repository at this point in the history

  2. Multiply blockwise

    @sethaxen
    sethaxen committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    ca261fd View commit details
    Browse the repository at this point in the history

  3. Use convert to avoid copy

    @sethaxen
    sethaxen committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    2b1ebd0 View commit details
    Browse the repository at this point in the history

  4. Use log_safe!

    @sethaxen
    sethaxen committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    34eba33 View commit details
    Browse the repository at this point in the history

  5. Avoid unnecessary copy

    @sethaxen
    sethaxen committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    d7ce927 View commit details
    Browse the repository at this point in the history

  6. Multiply blockwise to reduce allocations

    @sethaxen
    sethaxen committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    0ceb65b View commit details
    Browse the repository at this point in the history

  7. Increment version number

    @sethaxen
    sethaxen committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    296f107 View commit details
    Browse the repository at this point in the history

  8. remove windows from testing temporarily.

    @kellertuer
    kellertuer committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    2a2d8e7 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'kellertuer/steifel-canonical-metric' of github.com:Juli… 

    …aManifolds/Manifolds.jl into kellertuer/steifel-canonical-metric
    @kellertuer
    kellertuer committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    07d8598 View commit details
    Browse the repository at this point in the history