also redirect JL_STDERR etc. when redirecting to devnull #55958
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2024
Keno
reviewed
Oct 1, 2024
IanButterworth
added
backport 1.10
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
IanButterworth
force-pushed
the
ib/redirect_stdio_devnull_c
branch
3 times, most recently
from
a3f3589
to
6d14d91
Compare
|
@Keno can you take another look. I hadn't appreciated that it was |
IanButterworth
force-pushed
the
ib/redirect_stdio_devnull_c
branch
2 times, most recently
from
2ee5fbf
to
f4ca02f
Compare
IanButterworth
force-pushed
the
ib/redirect_stdio_devnull_c
branch
from
f4ca02f
to
9665f77
Compare
|
This appears to be a use-after-free because of the close call, so I am not sure this will work |
|
If I switch #55959 to use devnull, and add this change then I get the desired suppression without error, and CI seems happy here.
If the implementation isn't quite right, is there a better way? Use the handle after it's been |
This was referenced Oct 7, 2024
Merged
Merged
47 tasks
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any c prints to JL_STDERR will print during
redirect_stderr(f, devnull)