Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl completion shows qualification warning inline #55612

Closed
IanButterworth opened this issue Aug 28, 2024 · 7 comments · Fixed by #55959
Closed

repl completion shows qualification warning inline #55612

IanButterworth opened this issue Aug 28, 2024 · 7 comments · Fixed by #55959
Labels
completions Tab and autocompletion in the repl REPL Julia's REPL (Read Eval Print Loop)

Comments

@IanButterworth
Copy link
Member

julia> using Downloads

julia> download(WARNING: both Downloads and Base export "download"; uses of it in module Main must be qualified

i.e. typing download( will cause the warning to print.

@IanButterworth IanButterworth added the REPL Julia's REPL (Read Eval Print Loop) label Aug 28, 2024
@Keno
Copy link
Member

Keno commented Aug 29, 2024

Will be fixed by the full binding partition PR, since this will no longer by a binding resolution point.

@IanButterworth
Copy link
Member Author

Will that be backported to 1.11?

@Keno
Copy link
Member

Keno commented Aug 29, 2024

No

@IanButterworth
Copy link
Member Author

Ok. We need a solution for 1.11 then. Disable the check if in tab completion mode? Would that be possible?

@Keno
Copy link
Member

Keno commented Aug 29, 2024

It's not easy, because the warning is being emitted from deep in the binding resolution code as soon as someone asks the question about the binding.

@IanButterworth IanButterworth added the completions Tab and autocompletion in the repl label Sep 24, 2024
@IanButterworth
Copy link
Member Author

IanButterworth commented Oct 1, 2024

I looked into fixing this by disallowing anything to print to stdout/stderr during calls to complete_line, but redirect_stderr doesn't appear to redirect c prints that are to JL_STDERR. Is that expected?

Seems to be specific to devnull #55958

@IanButterworth
Copy link
Member Author

IanButterworth commented Oct 11, 2024

#55959 was reverted. This is fixed by removing the c warning, and on 1.11 by additionally backporting the improved hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completions Tab and autocompletion in the repl REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants