Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Pkg mode prompt immediately and load Pkg in the background #54594

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented May 28, 2024

Because Pkg is now a pkgimage and can load slowly on slower machines, which is a bit frustrating in the repl.

This makes the repl immediately switch to a dummy prompt that looks like Pkg mode to allow the user to keep typing while Pkg loads. During which the keymap is disabled.

It works best if julia has >1 thread, otherwise typing stalls during Pkg load.
Side note, it might make sense if by default julia in interactive mode started with at least -t1,1.

If Pkg takes longer to load than the user to type the command and press return, then the UX isn't great as it won't do anything.

Opening as a draft as the threading limitation is a bit awkward, and there may be a better approach to achieve the same UX.

Screen.Recording.2024-05-28.at.5.07.44.AM.mov

@IanButterworth IanButterworth added the REPL Julia's REPL (Read Eval Print Loop) label May 28, 2024
stdlib/REPL/src/REPL.jl Outdated Show resolved Hide resolved
@IanButterworth IanButterworth marked this pull request as ready for review June 1, 2024 04:53
@IanButterworth
Copy link
Member Author

I think even without >1 threads this is an improvement in UX responsiveness, so it should be good to go.

Reverts "Pkg REPL: cache `pkg_mode` lookup (JuliaLang#54359)"
as this function is replaced when Pkg loads by a simpler repl switch so no caching is needed
@IanButterworth IanButterworth added merge me PR is reviewed. Merge when all tests are passing backport 1.11 Change should be backported to release-1.11 labels Jun 1, 2024
@KristofferC KristofferC mentioned this pull request Jun 4, 2024
60 tasks
@IanButterworth IanButterworth merged commit 13635e1 into JuliaLang:master Jun 4, 2024
7 checks passed
@IanButterworth IanButterworth deleted the ib/fast_pkg_switch branch June 4, 2024 16:24
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Jun 4, 2024
@christiangnrd
Copy link
Contributor

This is great and makes a significant difference in how it feels to use the repl in master!

However, I noticed an issue that I demonstrate in the video. If you press enter before Pkg finishes loading (very possible when you want to start by checking the status of the current environment), nothing happens, and when you press enter again, it errors.

rplmodetoofast.mov

@IanButterworth
Copy link
Member Author

IanButterworth commented Jun 4, 2024

Thanks for the quick report, I can reproduce this. It's because we need to ignore the return char in the stdin capture during the load so that they don't get entered into the pkg prompt buffer, which doesn't usually happen.

Can you confirm that #54674 fixes this for you. Thanks

@christiangnrd
Copy link
Contributor

christiangnrd commented Jun 4, 2024

I'll respond in the new PR.

I also managed to cause some funky display behaviour when testing out 13635e1, but I can't remember how I did it. I'll report back if I figure it out. Same issue.

KristofferC pushed a commit that referenced this pull request Jun 7, 2024
…54594)

Because Pkg is now a pkgimage it can load slowly on slower machines,
which is a bit frustrating in the first repl switch.

This makes the repl immediately switch to a dummy prompt that looks like
Pkg mode to allow the user to keep typing while Pkg loads. During which
the keymap is disabled.

It works best if julia has >1 thread, otherwise typing stalls during Pkg
load.

If Pkg takes longer to load than the user to type the command and press
return, then the UX isn't great as it won't do anything.

https://github.com/JuliaLang/julia/assets/1694067/1bf17323-441a-4db2-8a3b-4d571eac622f
(cherry picked from commit 13635e1)
KristofferC added a commit that referenced this pull request Jun 25, 2024
Backported PRs:
- [x] #54361 <!-- [LBT] Upgrade to v5.9.0 -->
- [x] #54474 <!-- Unalias source from dest in copytrito -->
- [x] #54548 <!-- Fixes for bitcast bugs with LLVM 17 / opaque pointers
-->
- [x] #54191 <!-- make `AbstractPipe` public -->
- [x] #53402 <!-- Add `jl_getaffinity` and `jl_setaffinity` -->
- [x] #53356 <!-- Rename at-scriptdir project argument to at-script and
search upwards for Project.toml -->
- [x] #54545 <!-- typeintersect: fix incorrect innervar handling under
circular env -->
- [x] #54586 <!-- Set storage class of julia globals to dllimport on
windows to avoid auto-import weirdness. Forward port of #54572 -->
- [x] #54587 <!-- Accomodate for rectangular matrices in `copytrito!`
-->
- [x] #54617 <!-- CLI: Use `GetModuleHandleExW` to locate libjulia.dll
-->
- [x] #54605 <!-- Allow libquadmath to also fail as it is not available
on all systems -->
- [x] #54634 <!-- Fix trampoline assembly for build on clang 18 on apple
silicon -->
- [x] #54635 <!-- Aggressive constprop in trevc! to stabilize triangular
eigvec -->
- [x] #54645 <!-- ensure we set the right value to gc_first_tid -->
- [x] #54554 <!-- make elsize public -->
- [x] #54648 <!-- Construct LazyString in error paths for tridiag -->
- [x] #54658 <!-- fix missing uuid check on extension when finding the
location of an extension -->
- [x] #54594 <!-- Switch to Pkg mode prompt immediately and load Pkg in
the background -->
- [x] #54669 <!-- Improve error message in inplace transpose -->
- [x] #54671 <!-- Add boundscheck in bindingkey_eq to avoid OOB access
due to data race -->
- [x] #54672 <!-- make: Fix `sed` command for LLVM libraries with no
symbol versioning -->
- [x] #54624 <!-- more precise aliasing checks for SubArray -->
- [x] #54679 <!-- 🤖 [master] Bump the Distributed stdlib from 6a07d98 to
6c7cdb5 -->
- [x] #54604 <!-- Fix tbaa annotation on union selector bytes inside of
structs -->
- [x] #54690 <!-- Fix assertion/crash when optimizing function with dead
basic block -->
- [x] #54704 <!-- LazyString in reinterpretarray error messages -->
- [x] #54718 <!-- fix prepend StackOverflow issue -->
- [x] #54674 <!-- Reimplement dummy pkg prompt as standard prompt -->
- [x] #54737 <!-- LazyString in interpolated error messages involving
types -->
- [x] #54642 <!-- Document GenericMemory and AtomicMemory -->
- [x] #54713 <!-- make: use `readelf` for LLVM symbol version detection
-->
- [x] #54760 <!-- REPL: improve prompt! async function handler -->
- [x] #54606 <!-- fix double-counting and non-deterministic results in
`summarysize` -->
- [x] #54759 <!-- REPL: Fully populate the dummy Pkg prompt -->
- [x] #54702 <!-- lowering: Recognize argument destructuring inside
macro hygiene -->
- [x] #54678 <!-- Don't let setglobal! implicitly create bindings -->
- [x] #54730 <!-- Fix uuidkey of exts in fast path of `require_stdlib`
-->
- [x] #54765 <!-- Handle no-postdominator case in finalizer pass -->
- [x] #54591 <!-- Don't expose guard pages to malloc_stack API consumers
-->
- [x] #54755 <!-- [TOML] remove Dates hack, replace with explicit usage
-->
- [x] #54721 <!-- add try/catch around scheduler to reset sleep state
-->
- [x] #54631 <!-- Avoid concatenating LazyString in setindex! for
triangular matrices -->
- [x] #54322 <!-- effects: add new `@consistent_overlay` macro -->
- [x] #54785
- [x] #54865
- [x] #54815
- [x] #54795
- [x] #54779
- [x] #54837 

Contains multiple commits, manual intervention needed:
- [ ] #52694 <!-- Reinstate similar for AbstractQ for backward
compatibility -->
- [ ] #54649 <!-- Less restrictive copyto! signature for triangular
matrices -->

Non-merged PRs with backport label:
- [ ] #54779 <!-- make recommendation clearer on manifest version
mismatch -->
- [ ] #54739 <!-- finish implementation of upgradable stdlibs -->
- [ ] #54738 <!-- serialization: fix relocatability bug -->
- [ ] #54574 <!-- Make ScopedValues public -->
- [ ] #54457 <!-- Make `String(::Memory)` copy -->
- [ ] #53957 <!-- tweak how filtering is done for what packages should
be precompiled -->
- [ ] #53452 <!-- RFC: allow Tuple{Union{}}, returning Union{} -->
- [ ] #53286 <!-- Raise an error when using `include_dependency` with
non-existent file or directory -->
- [ ] #51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants