Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load Pkg when hitting Pkg repl history #51921

Closed

Conversation

IanButterworth
Copy link
Member

Previously, since Pkg was moved out of the sysimage, Pkg entries in history would be skipped until Pkg was loaded.

@IanButterworth IanButterworth added REPL Julia's REPL (Read Eval Print Loop) stdlib Julia's standard library labels Oct 29, 2023
@KristofferC
Copy link
Member

I've been somewhat annoyed about this too but:

  • It feels a bit "heavy-handed" to load all of Pkg when scrolling through history.
  • It doesn't help with reverse search.

So maybe this is a good idea but it is perhaps worth pondering over it for a while if something else could be done.

@IanButterworth
Copy link
Member Author

IanButterworth commented Mar 9, 2024

What about this one @KristofferC @Keno

Maybe we just load like this in 1.11 to avoid regression and then try to make a lighter weight history that doesn't load Pkg until the command is executed, or something?

@JeffBezanson
Copy link
Member

Idea from @vtjnash: make all history entries always visible, but if one is from a mode that's not available use a fallback prompt mode where the text is grayed out and gives a "Pkg not loaded" error if you try to run it. Maybe also make the prompt text un-editable.

@IanButterworth
Copy link
Member Author

We could pair that with the same dummy pkg prompt from #54594

@IanButterworth
Copy link
Member Author

#54674 now allows scrolling through the dummy Pkg prompt if Pkg isn't loaded, then loads Pkg and executes on return.

@IanButterworth IanButterworth deleted the ib/pkg_load_history branch June 5, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REPL Julia's REPL (Read Eval Print Loop) stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants