Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps/libsuitesparse: fix empty var in manifest #50997

Merged
merged 2 commits into from
Aug 21, 2023
Merged

deps/libsuitesparse: fix empty var in manifest #50997

merged 2 commits into from
Aug 21, 2023

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Aug 21, 2023 •
edited
Loading

UNINSTALL_libsuitesparse is an empty variable (used in

julia/deps/libsuitesparse.mk

Line 66 in 74ce6cf

echo $(UNINSTALL_libsuitesparse) > $@
): this leads to an empty usr/manifest/libsuitesparse file.

Maybe Makefiles should check for empty manifests and error properly, making the build system more robust ?

@staticfloat staticfloat merged commit 78d5bfe into JuliaLang:master Aug 21, 2023
@t-bltg t-bltg deleted the ssparse_bld branch August 21, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-bltg @staticfloat