Skip to content

Commit

Permalink
deps/libsuitesparse: fix empty var in manifest (#50997)
Browse files Browse the repository at this point in the history 
`UNINSTALL_libsuitesparse` is an empty variable (used in
https://github.com/JuliaLang/julia/blob/74ce6cf070a2a04e836c3e5a2211228a3ac978ef/deps/libsuitesparse.mk#L66):
this leads to an empty `usr/manifest/libsuitesparse` file.

Maybe `Makefile`s should check for empty manifests and error properly,
making the build system more robust ?
  • Loading branch information
@t-bltg
t-bltg authored Aug 21, 2023
1 parent 430a74e commit 78d5bfe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deps/libsuitesparse.mk
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/build-checked: $(BUILDDIR)/SuiteSp
done
echo 1 > $@

UNINSTALL_suitesparse := $(LIBSUITESPARSE_VER) manual_suitesparse $(LIBSUITESPARSE_LIBS)
UNINSTALL_libsuitesparse := $(LIBSUITESPARSE_VER) manual_libsuitesparse $(LIBSUITESPARSE_LIBS)

$(build_prefix)/manifest/libsuitesparse: $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/build-compiled | $(build_prefix)/manifest $(build_shlibdir)
echo $(UNINSTALL_libsuitesparse) > $@
Expand Down

2 comments on commit 78d5bfe

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Please sign in to comment.