Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LibGit2] fix wrong definition of ConfigStruct #50247

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jun 21, 2023

This is not something users are allowed to construct, it was missing a field, and the last field is never allowed to be a Julia pointer.

Ref libgit2/libgit2@26cf48f

This is not something users are allowed to construct, it was missing a
field, and the last field is never allowed to be a Julia pointer.
@vtjnash vtjnash added libgit2 The libgit2 library or the LibGit2 stdlib module backport 1.9 Change should be backported to release-1.9 labels Jun 21, 2023
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Jun 21, 2023
@IanButterworth IanButterworth merged commit e7d00e1 into master Jun 21, 2023
@IanButterworth IanButterworth deleted the jn/libgit2-configstruct-error branch June 21, 2023 23:41
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jun 24, 2023
KristofferC pushed a commit that referenced this pull request Jun 26, 2023
@KristofferC KristofferC mentioned this pull request Jun 26, 2023
36 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants