Backports for 1.9.2 #50090
Merged
Backports for 1.9.2 #50090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update calling-c-and-fortran-code.md Drop mentioning Cxx.jl (cherry picked from commit e998367)
(cherry picked from commit e169d20)
In some rare cases with callsite inlining, we try to inline an inferred result from a local cache (`inf_result::InferenceResult`), whose source has been transformed by `transform_result_for_cache`. At present, `inf_result.src` stays to be `OptimizationState` in such cases, causing `inlining_policy` to handle the callsite inlining. This commit adjusts `transform_result_for_cache` so that it stores the transformed source in `inf_result.src`, letting the callsite inliner use it. Down the line, we might revisit this change to align it with 532125d, which isn't enabled yet. (cherry picked from commit f407a4c)
There are cases when `joint_effects` already has `:nothrow` tainted while the matches are fully covered.
aviatesk
force-pushed
the
backports-release-1.9
branch
from
f5c0240
to
1c11fb2
Compare
This makes it so libgit2.so and libssh2.so go into `usr/lib` where they should be, rather than into `usr/lib64` on some platforms.
Fixes for the `1.9.1-full` tarball
Co-authored-by: Valentin Churavy <[email protected]> (cherry-picked from commit 4ef9fb1)
This comment was marked as resolved.
This comment was marked as resolved.
…7890 (#50262) Co-authored-by: Dilum Aluthge <[email protected]>
Ensure the lock is precise, so that we are allowed to register new atexit hooks from inside an atexit hook. But then disable `atexit()` when shutting down after it finishes running. Add tests that cover all the cases: 1. registering a hook from inside a hook 2. registering a hook from another thread while hooks are running 3. attempting to register a hook after all hooks have finished (disallowed) Fixes #49841 Co-authored-by: Jameson Nash <[email protected]> (cherry picked from commit 20752db)
(cherry picked from commit e111c01)
This build includes a fix from GCC 12.2 for a bug in libgomp 12.1 which was causing frequent crashes on Windows in third-party libraries. (cherry picked from commit a81398f)
* Add check call to getrf! `lu!(A; check=false)` is supposed to disable the checking and leave it to the user: > When check = true, an error is thrown if the decomposition fails. When check = false, responsibility for checking the decomposition's validity (via issuccess) lies with the user. However, this is not quite true since `lu!` calls `getrf!` which internally does a check for `chkfinite` which does throw an error. This updates the `getrf!` function to have a `check` argument which is then used by `lu!` to fully disable the error throwing checks. * Update lapack.jl (cherry picked from commit d69b1a2)
Co-authored-by: Julian Samaroo <[email protected]> (cherry picked from commit 9d1ac97)
(cherry picked from commit 432f300)
…tal precompilation In rare cases, if we fail to load a dependency during precompilation, we can fall-through to the "load locally" fallthrough in `_require()`. However, if this happens during incremental precompilation, this ends up emitting `.ji` files that have multiple modules embedded within, which can cause massive precompilation issues further down the chain, as dependencies which try to load our `.ji` file themselves get corrupted. This catches the error at the source, refusing to generate such a `.ji` file in the first place. (cherry picked from commit 9032926)
(cherry picked from commit e7d00e1)
The `run` method no longer throws an `ErrorException` on failure. It currently throws a `ProcessFailedException`. (cherry picked from commit c0f623d)
KristofferC
force-pushed
the
backports-release-1.9
branch
from
84e54dc
to
0857574
Compare
hmm |
* don't define hash(::BigInt) on 32 bit systems (cherry picked from commit c3ea5dc)
…hod (#49777) Previously `@enum` defined `Base.hash(::MyEnumType, ::UInt)` on the user-defined enum type `MyEnumType`. When the user wants to specialize the hash function for his own enum type he will define exactly that method signature again which overwrites it and leads to the warning WARNING: Method definition hash(TestPackage.MyEnumType, UInt64) in module TestPackage at Enums.jl:210 overwritten at [...] ** incremental compilation may be fatally broken for this module ** This commit changes `@enum` so that an internal method is used instead which is called through a fallback `Base.hash(::Enum, ::UInt)`. (cherry picked from commit 22551a2)
* jltypes: add missing GC root for cmpswap_type Tuple.
This is called with a fieldtype, which might not even be a DataType.
* support Ptr{Union{}} and Ptr{Cvoid} better
(cherry picked from commit bd5e6da)
KristofferC
force-pushed
the
backports-release-1.9
branch
from
50c8611
to
132a548
Compare
|
I think we removed that Tuple{Union{}} test / functionality in v1.10 anyways, due to correctness reasons |
|
Do you have a reference to that? |
|
@nanosoldier |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
Your package evaluation job has completed - possible new issues were detected. |
|
@nanosoldier |
|
Your package evaluation job has completed - no new issues were detected. |
Co-authored-by: Mason Protter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
Threads.@spawn#50182SuiteSparse_jll: onlydlopenthe libraries ifBase.USE_GPL_LIBSis true #50267apply_type_nothrowrobust againstTypeVars in upper bounds #49863similar#49392hash(::BigInt)on 32 bit systems #500761.9.1-fulltarball #50252hashfor custom enum subtypes #49964MissingOptimization) that come up when using SortingAlgorithms.TimSort #50171Need manual backport:
Contains multiple commits, manual intervention needed:
DelimitedFiles#49582Non-merged PRs with backport label:
--heap-size-hintarg handling #48050