Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak source distribution tarball construction. #43096

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Nov 15, 2021

Mea culpa. Ref. #43003 (comment). Best!

Makefile Outdated Show resolved Hide resolved
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Nov 15, 2021
@DilumAluthge DilumAluthge merged commit d958c8c into master Nov 16, 2021
@DilumAluthge DilumAluthge deleted the sv-unbreak-tarball branch November 16, 2021 03:56
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Nov 16, 2021
KristofferC pushed a commit that referenced this pull request Nov 19, 2021
Co-authored-by: Jameson Nash <[email protected]>
(cherry picked from commit d958c8c)
KristofferC pushed a commit that referenced this pull request Nov 26, 2021
Co-authored-by: Jameson Nash <[email protected]>
(cherry picked from commit d958c8c)
@Sacha0 Sacha0 added the backport 1.6 Change should be backported to release-1.6 label Dec 11, 2021
@Sacha0
Copy link
Member Author

Sacha0 commented Dec 11, 2021

Looks like 1.6.5 source distributions are broken for lack of this fix. My bad, I should have tagged this pull request for backport to 1.6 in addition to 1.7. Added the tag just now.

Sacha0 added a commit that referenced this pull request Dec 11, 2021
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jan 10, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants