-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak source distribution tarball construction. #43096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Nov 15, 2021
DilumAluthge
removed
the
merge me
PR is reviewed. Merge when all tests are passing
label
Nov 16, 2021
KristofferC
pushed a commit
that referenced
this pull request
Nov 19, 2021
Co-authored-by: Jameson Nash <[email protected]> (cherry picked from commit d958c8c)
29 tasks
KristofferC
pushed a commit
that referenced
this pull request
Nov 26, 2021
Co-authored-by: Jameson Nash <[email protected]> (cherry picked from commit d958c8c)
Looks like 1.6.5 source distributions are broken for lack of this fix. My bad, I should have tagged this pull request for backport to 1.6 in addition to 1.7. Added the tag just now. |
Sacha0
added a commit
that referenced
this pull request
Dec 11, 2021
Co-authored-by: Jameson Nash <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Co-authored-by: Jameson Nash <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Co-authored-by: Jameson Nash <[email protected]>
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Co-authored-by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mea culpa. Ref. #43003 (comment). Best!