Stop stripping git, github, and CI config files from source distributions. #43003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Nov 8, 2021
Sacha0
force-pushed
the
sv-keep-hidden
branch
from
44bbd91
to
cb4295f
Compare
staticfloat
approved these changes
Nov 9, 2021
Sacha0
force-pushed
the
sv-keep-hidden
branch
from
cb4295f
to
780ebea
Compare
Sacha0
added
backport 1.6
29 tasks
|
I suspect this commit broke the tarballs: On closer inspection, the dropped line appears to be responsible for most of the population of the tarball. |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripping these files from source distributions makes it difficult to, e.g., apply the diff between backports-release-1.x and release-1.x branches to release-1.x source distributions. (Parts of the diff that touch the stripped files must themselves be stripped, which can be done with e.g. filterdiff but not reliably.)
I guess that once this patch lands on master, the change will immediately propagate to the -latest source distributions, but will need to be backported to release-1.x branches to take effect there?
Best!