Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create new tasks in the parent world #41449

Merged
merged 1 commit into from
Sep 15, 2021
Merged

create new tasks in the parent world #41449

merged 1 commit into from
Sep 15, 2021

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jul 2, 2021

N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes #35690
Closes #41332

@vtjnash vtjnash added the minor change Marginal behavior change acceptable for a minor release label Jul 2, 2021
@vtjnash vtjnash requested a review from JeffBezanson July 2, 2021 14:27
DilumAluthge
DilumAluthge reviewed Jul 2, 2021
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
tkf
tkf reviewed Jul 2, 2021
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@vtjnash vtjnash added the needs docs Documentation for this change is required label Jul 2, 2021
@JeffBezanson JeffBezanson added the multithreading Base.Threads and related functionality label Jul 6, 2021
@vtjnash
create new tasks in the parent world
ab9156c 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes #35690
Closes #41332
@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing and removed needs docs Documentation for this change is required labels Jul 13, 2021
@fredrikekre
Copy link
Member

@nanosoldier runtests(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Something went wrong when running your job:

ProcessExitedException(2)

cc @maleadt

@vtjnash vtjnash removed the merge me PR is reviewed. Merge when all tests are passing label Jul 13, 2021
@vtjnash
Copy link
Member Author

vtjnash commented Jul 13, 2021

@nanosoldier runbenchmarks("parallel", vs = ":master")

@vtjnash
Copy link
Member Author

vtjnash commented Jul 13, 2021

PkgEval has been broken since circa 2dd34c1#commitcomment-53260879 almost a week ago

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - no performance regressions were detected. A full report can be found here. cc @christopher-dG

@JeffBezanson
Copy link
Member

I'll plan to merge this right after 1.7 is released.

@vtjnash
Copy link
Member Author

vtjnash commented Jul 13, 2021

v1.7 branched awhile ago

@JeffBezanson
Copy link
Member

@nanosoldier runtests(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@vtjnash
Copy link
Member Author

vtjnash commented Aug 25, 2021

A couple related ones to fix first: @nanosoldier runtests(["Dance", "Diagonalizations", "DynamicalBilliards", "FameSVD", "FilesystemDatastructures", "ForneyLab", "GeometricProblems", "GoogleCodeSearch", "GtkObservables", "HypertextLiteral", "InteractBase", "Lale", "PowerGraphics", "RemoveLFS", "SalesForceBulkApi", "Signals", "StochasticDelayDiffEq", "StochasticRounding", "Symbolics"], vs = ":master")

@DilumAluthge
Copy link
Member

PkgEval has been broken since circa 2dd34c1#commitcomment-53260879 almost a week ago

Looks like PkgEval is fixed now?

@maleadt

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@vtjnash
Copy link
Member Author

vtjnash commented Sep 1, 2021 •
edited
Loading

GoogleCodeSearch -- caused by JuliaWeb/HTTP.jl#747, no fix yet (@quinnj)
HypertextLiteral -- fixed by MechanicalRabbit/NarrativeTest.jl#1
Signals -- fixed by TsurHerman/Signals.jl#14
Symbolics -- unreliable test in Symbolics.jl? (@YingboMa)

@vtjnash vtjnash merged commit 1c3c4d8 into master Sep 15, 2021
@vtjnash vtjnash deleted the jn/41332 branch September 15, 2021 19:17
aviatesk added a commit to JunoLab/Atom.jl that referenced this pull request Sep 16, 2021
@aviatesk
update to JuliaLang/julia#41449
e8caf80 
With that commit, `Task` won't run in the latest global world age, so we
want to add manual `invokelatest` to dynamically update `handlers`.
aviatesk added a commit to JunoLab/Atom.jl that referenced this pull request Sep 16, 2021
@aviatesk
update to JuliaLang/julia#41449 (#375)
37bb251 
With that commit, `Task` won't run in the latest global world age, so we
want to add manual `invokelatest` to dynamically update `handlers`.
KristofferC pushed a commit that referenced this pull request Sep 28, 2021
@vtjnash @KristofferC
create new tasks in the parent world (#41449)
11ed8e1 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes #35690
Closes #41332
@vchuravy vchuravy mentioned this pull request Oct 6, 2021
Merged
@tkf tkf mentioned this pull request Jan 27, 2022
Merged
@garrison garrison mentioned this pull request Feb 14, 2022
Merged
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@vtjnash @LilithHafner
create new tasks in the parent world (JuliaLang#41449)
59aa429 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes JuliaLang#35690
Closes JuliaLang#41332
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@vtjnash @LilithHafner
create new tasks in the parent world (JuliaLang#41449)
db55112 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes JuliaLang#35690
Closes JuliaLang#41332
@caleb-allen caleb-allen mentioned this pull request Oct 24, 2022
Closed
Keno pushed a commit that referenced this pull request Jun 5, 2024
@vtjnash
create new tasks in the parent world (#41449)
ac83e57 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes #35690
Closes #41332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge DilumAluthge left review comments

@tkf tkf tkf left review comments

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
minor change Marginal behavior change acceptable for a minor release multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

start new tasks in the parent world? what world should Tasks run in?
6 participants
@vtjnash @fredrikekre @nanosoldier @JeffBezanson @DilumAluthge @tkf