Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start new tasks in the parent world? #41332

Closed
vtjnash opened this issue Jun 23, 2021 · 2 comments · Fixed by #41449
Closed

start new tasks in the parent world? #41332

vtjnash opened this issue Jun 23, 2021 · 2 comments · Fixed by #41449
Labels
design Design of APIs or of the language itself minor change Marginal behavior change acceptable for a minor release multithreading Base.Threads and related functionality

Comments

@vtjnash
Copy link
Member

vtjnash commented Jun 23, 2021

Currently Tasks always launch in the newest world age. This blocks inference, and some optimizations. Would anyone's code break if we instead launched them in the parent world of the task that allocated it?
@vtjnash vtjnash added multithreading Base.Threads and related functionality design Design of APIs or of the language itself minor change Marginal behavior change acceptable for a minor release labels Jun 23, 2021
@fredrikekre
Copy link
Member

#35690

@JeffBezanson
Copy link
Member

Yes we should definitely do this. It's a no-brainer for inference as well as a general cilk-like view of the world where parallel execution is an implementation detail of a serial program. Easy to get the current behavior with @spawn @invokelatest ....

vtjnash added a commit that referenced this issue Jul 2, 2021
@vtjnash
create new tasks in the parent world
695621a 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes #35690
Closes #41332
vtjnash added a commit that referenced this issue Jul 2, 2021
@vtjnash
create new tasks in the parent world
d04d97e 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes #35690
Closes #41332
@vtjnash vtjnash mentioned this issue Jul 2, 2021
Merged
vtjnash added a commit that referenced this issue Jul 13, 2021
@vtjnash
create new tasks in the parent world
ab9156c 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes #35690
Closes #41332
vtjnash added a commit that referenced this issue Sep 15, 2021
@vtjnash
create new tasks in the parent world (#41449)
1c3c4d8 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes #35690
Closes #41332
KristofferC pushed a commit that referenced this issue Sep 28, 2021
@vtjnash @KristofferC
create new tasks in the parent world (#41449)
11ed8e1 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes #35690
Closes #41332
LilithHafner pushed a commit to LilithHafner/julia that referenced this issue Feb 22, 2022
@vtjnash @LilithHafner
create new tasks in the parent world (JuliaLang#41449)
59aa429 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes JuliaLang#35690
Closes JuliaLang#41332
LilithHafner pushed a commit to LilithHafner/julia that referenced this issue Mar 8, 2022
@vtjnash @LilithHafner
create new tasks in the parent world (JuliaLang#41449)
db55112 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes JuliaLang#35690
Closes JuliaLang#41332
Keno pushed a commit that referenced this issue Jun 5, 2024
@vtjnash
create new tasks in the parent world (#41449)
ac83e57 
N.B. This means serialized tasks will discard this stateful information
and pick up new/different information.

Closes #35690
Closes #41332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Design of APIs or of the language itself minor change Marginal behavior change acceptable for a minor release multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

create new tasks in the parent world JuliaLang/julia
3 participants
@vtjnash @JeffBezanson @fredrikekre