fix #39982, reduce cursor artifacts in REPL after #39538 #40411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Apr 9, 2021
| write(termbuf, spin_seq[mod1(position(buf) - w, length(spin_seq))]) | ||
| cmove_left(termbuf) | ||
| if spinner | ||
| write(termbuf, spin_seq[mod1(position(buf) - w, length(spin_seq))]) |
There was a problem hiding this comment.
I think now that str[end] may be a better choice than spin_seq[*] also. But would need to test that theory.
vtjnash
added a commit
that referenced
this pull request
Apr 12, 2021
vtjnash
added a commit
that referenced
this pull request
Apr 12, 2021
JeffBezanson
pushed a commit
that referenced
this pull request
Apr 14, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two tweaks to the delayed-update code:
These can be separated if people prefer.
fix #39982