Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor progress indicator artefact in REPL #39982

Closed
knuesel opened this issue Mar 11, 2021 · 5 comments · Fixed by #40411
Closed

Cursor progress indicator artefact in REPL #39982

knuesel opened this issue Mar 11, 2021 · 5 comments · Fixed by #40411
Labels
REPL Julia's REPL (Read Eval Print Loop)

Comments

@knuesel
Copy link
Member

knuesel commented Mar 11, 2021

On master (bb5a013) there is a visual artefact in the REPL when typing text in front of a character, not present in 1.6-rc1:

screencast.mp4

The video looks slowed-down, it's not so clear in real life but it does look weird.

@KristofferC
Copy link
Member

#39538 probably.

@vtjnash
Copy link
Member

vtjnash commented Mar 11, 2021

yes, it's only there for 15ms or so (greatly depending on the performance of your terminal) to visually indicate some characters are being inserted, until we can refresh the whole screen to show them

@vtjnash
Copy link
Member

vtjnash commented Mar 11, 2021

I guess what we should do though is optimistically insert the user's character first on the first key press, then start the spinner on the 2nd key press, to minimize visual tearing

@vtjnash vtjnash added the REPL Julia's REPL (Read Eval Print Loop) label Mar 11, 2021
@KristofferC
Copy link
Member

Or maybe just not have the spinner?

@JeffBezanson
Copy link
Member

I also find this change not so great, on linux at least. In addition to this issue, when holding down a key it looks like text is being overwritten even though it's not, which is disconcerting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants