Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made \brokenbar ¦ and \notslash ⌿ infix. fixes #34651 #37973

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Made \brokenbar ¦ and \notslash ⌿ infix. fixes #34651 #37973

merged 1 commit into from
Oct 14, 2020

Conversation

ravibitsgoa
Copy link
Contributor

@ravibitsgoa ravibitsgoa commented Oct 10, 2020 •
edited
Loading

Fixes #34651

@ravibitsgoa ravibitsgoa changed the title Made \brokenbar ¦ and \notslash ⌿ infix. #34651 Made \brokenbar ¦ and \notslash ⌿ infix. fixes #34651 Oct 10, 2020
@ravibitsgoa
Copy link
Contributor Author

@JeffBezanson , Can this PR be merged if it is satisfactory?

@JeffBezanson JeffBezanson merged commit ae2c61d into JuliaLang:master Oct 14, 2020
@stevengj
Copy link
Member

Needs a NEWS item

@JeffBezanson
Copy link
Member

Ah, turns out this does not quite work yet, since these characters are in the "So" category. is_wc_cat_id_start needs to be modified as well.

@stevengj
Copy link
Member

So this is technically a breaking change since they are valid parts of identifiers in 1.5:

julia> x¦ = 3
3

julia> x⌿ = 7
7

I doubt that it will break anything in practice, but should we revert the patch and create a new PR with the modifications to is_wc_cat_id_start and NEWS and then run pkgeval?

@fredrikekre fredrikekre added needs news A NEWS entry is required for this change needs tests Unit tests are required for this change labels Oct 18, 2020
@JeffBezanson
Copy link
Member

JuliaHub code search doesn't turn up any results, so it's probably ok.

JeffBezanson added a commit that referenced this pull request Oct 19, 2020
@JeffBezanson
fix up addition of ¦ and ⌿ operators (#37973)
cf45635
@JeffBezanson JeffBezanson mentioned this pull request Oct 19, 2020
Merged
@ravibitsgoa ravibitsgoa deleted the ravibitsgoa/infix branch October 20, 2020 17:06
JeffBezanson added a commit that referenced this pull request Oct 20, 2020
@JeffBezanson
fix up addition of ¦ and ⌿ operators (#37973) (#38100)
57f07e3
@tlienart tlienart mentioned this pull request Nov 2, 2020
Merged
ViralBShah added a commit that referenced this pull request Nov 10, 2020
@tlienart @ViralBShah
Typo fix in NEWS.md (#38266)
8fc3221 
There's also a bunch of issue links that are missing (#37410, #37247, #37540, #37973, #37461, #37753) but it seems there's a script that generates the links so I'm assuming that will be fixed automatically.

Co-authored-by: Viral B. Shah <[email protected]>
achuchmala pushed a commit to achuchmala/julia that referenced this pull request Nov 11, 2020
@tlienart @ViralBShah
Typo fix in NEWS.md (JuliaLang#38266)
e08a22a 
There's also a bunch of issue links that are missing (JuliaLang#37410, JuliaLang#37247, JuliaLang#37540, JuliaLang#37973, JuliaLang#37461, JuliaLang#37753) but it seems there's a script that generates the links so I'm assuming that will be fixed automatically.

Co-authored-by: Viral B. Shah <[email protected]>
@t-bltg t-bltg mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
needs news A NEWS entry is required for this change needs tests Unit tests are required for this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

\brokenbar ¦ and \notslash ⌿ should be parsed infix
4 participants
@ravibitsgoa @stevengj @JeffBezanson @fredrikekre