Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

\brokenbar ¦ and \notslash ⌿ should be parsed infix #34651

Closed
zenna opened this issue Feb 4, 2020 · 2 comments · Fixed by #37973
Closed

\brokenbar ¦ and \notslash ⌿ should be parsed infix #34651

zenna opened this issue Feb 4, 2020 · 2 comments · Fixed by #37973
Labels
good first issue Indicates a good issue for first-time contributors to Julia parser Language parsing and surface syntax

Comments

@zenna
Copy link

zenna commented Feb 4, 2020

As the title says, unless there is a compelling reason otherwise it seems that \brokenbar ¦ should be parsed infix, for consistency with all the other bars.

So should \notslash ⌿, perhaps.
@JeffBezanson JeffBezanson added the parser Language parsing and surface syntax label Feb 6, 2020
@JeffBezanson JeffBezanson added the good first issue Indicates a good issue for first-time contributors to Julia label Feb 29, 2020
@amCap1712
Copy link

Hi! I am interested in working on this. Any pointers where I should start @JeffBezanson ?

@stevengj
Copy link
Member

You would just add them to the operator definitions in src/julia-parser.scm. In particular, ¦ should go in prec-plus alongside | and ⌿ would go in prec-times alongside /.

@ravibitsgoa ravibitsgoa mentioned this issue Oct 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Indicates a good issue for first-time contributors to Julia parser Language parsing and surface syntax
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made \brokenbar ¦ and \notslash ⌿ infix. fixes #34651 ravibitsgoa/julia
4 participants
@zenna @JeffBezanson @stevengj @amCap1712