Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port v1.1 NEWS changes to HISTORY #30592

Closed
wants to merge 1 commit into from

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Jan 4, 2019

Mirrors the change of #30562 in NEWS.md of release-1.1 branch to HISTORY.md of master branch.

@JeffBezanson
Copy link
Member

Thanks! In fact, maybe we should combine this with #30559. The news item from #30453 also needs to be copied to HISTORY on master. The following change is also missing on master:

-  * Added keyword arguments `rtol`, `atol` to `rank` ([#29926]).
+  * Added keyword arguments `rtol`, `atol` to `pinv`, `nullspace` and `rank` ([#29998], [#29926]).

@ViralBShah ViralBShah changed the title Missing backsticks Missing backticks Jan 4, 2019
@blegat blegat force-pushed the backstick-history branch from 7907b6a to f8f3f10 Compare January 11, 2019 16:54
@blegat blegat changed the title Missing backticks Port v1.1 NEWS changes to HISTORY Jan 14, 2019
@Keno
Copy link
Member

Keno commented Jan 17, 2020

This has a broken markdown footnote. In general, we should work out a process for changes that happen to NEWS.md after the merge.

@StefanKarpinski
Copy link
Member

Might be good to do some kind of directory of small news snippets with files named by PR numbers and then have a script to generate the NEWS file from that. Would address the conflict issue as well.

@Keno
Copy link
Member

Keno commented Jan 18, 2020

My suggestion would be to add some commit message convention, e.g.:

Add awesome language feature

This adds my awesome language feature. It's so awesome, it deserves to be mentioned in NEWS

```news
# Language changes

* I've added a really awesome feature.
```

Then, on the release branch, we scrape the commit log and generate NEWS.md from scratch, allow people to manually make any edits while the release stabilizes and once the release closes, prepend the NEWS.md from the commit branch to HISTORY.md. In particular, master would never have a NEWS.md branch.

@KristofferC
Copy link
Member

KristofferC commented Apr 8, 2021

Doesn't seem useful anymore.

@KristofferC KristofferC closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants