-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature (workflow) request: conflict-free way of creating NEWS.md #34332
Comments
I made a suggestion here: #30592 (comment). It's similar to the numpy approach, but lets people write snippets explicitly in the commit message to end up in NEWS. I think that's better than automatically adding every commit message to NEWS, since a lot of them may not be NEWS worthy. |
I dislike that approach because it’s non-obvious how to edit a NEWS entry after the fact. It seems like you’d have to generate the NEWS file and then edit it? What happens if it gets regenerated again later? With a directory full of snippets, it’s obvious how to edit each one. It’s weird for input to the build to come from the commit log. |
I'm not suggesting it be an input to the build, I'm suggesting that NEWS.md be generated once as part of the release branch creation process and then edited into the actual release notes. I guess it doesn't matter too much whether it's a separate file or part of the commit message. Maybe the file thing is just simpler and cleaner. |
So in the file model, to make a release branch we'd then in the same commit bump the version number, and remove the NEWS.md chunks, and then the first commit on the release branch is to create a merged NEWS.md file? |
That's what I was thinking. |
Git itself actually supports per-file configurable merge-drivers (using So I somewhat see this issue as a GitHub limitation and people have been asking for this feature for a long time. If someone can get GitHub to support that it would certainly be the easiest option. |
Thanks. I didn't know about the merge driver. It sounds super useful. I still think "news fragment file" is a good solution, though. We need to create the links to the issues with a script anyway. |
As an occasional contributor, I find resolving conflict in
NEWS.md
rather cumbersome, especially when it is the only conflict that is blocking review/merge. For large projects, I think it's common to create a news file in a conflict-free manner. Can you implement such a work flow in Julia?Here's a few examples that I know:
Generate a single news file from "news fragments":
CPython: Use CLI
blurb
to generate a news file from files inMisc/NEWS.d/
.IPython: Use a custom script to merge news files: https://github.com/ipython/ipython/tree/master/docs/source/whatsnew/pr
Generate a news file using GitHub API:
ENH
andBUG
).The text was updated successfully, but these errors were encountered: