Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move nprocs and myid to Distributed #25139

Merged
merged 2 commits into from
Dec 22, 2017
Merged

move nprocs and myid to Distributed #25139

merged 2 commits into from
Dec 22, 2017

Conversation

vchuravy
Copy link
Member

I was trying to fix the logic in #25119 while also optimising myid and nprocs
and I think it is better to fully deprecate them.

@vtjnash mentioned to me that the usage of object_number is most likely incorrect,
but I do not understand the code well enough to attempt a fix, so I went with the minimal solution.

fixes #25077
fixes #25135

replaces #25119

@vchuravy vchuravy added deprecation This change introduces or involves a deprecation stdlib Julia's standard library labels Dec 17, 2017
@StefanKarpinski
Copy link
Member

cc @amitmurthy

@vchuravy vchuravy force-pushed the vc/distributed2 branch 2 times, most recently from e1a0a70 to e3881f2 Compare December 18, 2017 02:52
Copy link
Contributor

@amitmurthy amitmurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vchuravy
Copy link
Member Author

@vtjnash The I am seeing ssertion !NameRef.empty() && "Normal symbols cannot be unnamed!"'` failed. on 32bit CircleCI: https://gist.github.com/vchuravy/ff6037267644e56fce9c78b1ec4df183

Has anybody seen the Error deserializing a remote exception before?

RemoteException(23, CapturedException(ErrorException("could not open file /tmpz9VYTm"), Any[(include at boot.jl:286 [inlined], 1), (include_relative at loading.jl:493, 1), (include at sysimg.jl:26, 1), (include at sysimg.jl:65, 1), (#122 at process_messages.jl:269, 1), (run_work_thunk at process_messages.jl:56, 1), (macro expansion at process_messages.jl:269 [inlined], 1), (#121 at event.jl:92, 1)]))


Distributed (1)           |  214.58  |  0.01  |  0.0 |  6.82      | 304.08  
libgit2: Error During Test at nothing:1
  Test threw an exception of type RemoteException
  Expression: libgit2
  Error deserializing a remote exception from worker 10
  Remote(original) exception of type Test.TestSetException
  Remote stacktrace : 
  finish at /home/circleci/project/usr/share/julia/site/v0.7/Test/src/Test.jl:778
  macro expansion at ./util.jl:310 [inlined]
  top-level scope at ./<missing>:19
  eval at ./boot.jl:289
  #runtests#1 at /tmp/julia/share/julia/test/testdefs.jl:25
  #runtests at ./<missing>:0 [inlined] (repeats 2 times)
  #122 at /home/circleci/project/usr/share/julia/site/v0.7/Distributed/src/process_messages.jl:269
  run_work_thunk at /home/circleci/project/usr/share/julia/site/v0.7/Distributed/src/process_messages.jl:56
  macro expansion at /home/circleci/project/usr/share/julia/site/v0.7/Distributed/src/process_messages.jl:269 [inlined]
  #121 at ./event.jl:92

@amitmurthy
Copy link
Contributor

Has anybody seen the Error deserializing a remote exception before?

In this case, it appears that Test.TestSetException is not exported and hence the deserialization of the RemoteException (which wraps the TestSetException) is failing.

@amitmurthy
Copy link
Contributor

amitmurthy commented Dec 21, 2017

The actual test failure should be at

finish at /home/circleci/project/usr/share/julia/site/v0.7/Test/src/Test.jl:778

@vchuravy
Copy link
Member Author

ok modulo CI, I plan to merge this later today.

@vchuravy
Copy link
Member Author

The elusive 5/5

@vchuravy vchuravy merged commit 26cbf72 into master Dec 22, 2017
@vchuravy vchuravy deleted the vc/distributed2 branch December 22, 2017 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This change introduces or involves a deprecation stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate myid and nprocs fully Optimize myid and nprocs after moving Distributed to stdlib
3 participants