-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move nprocs
and myid
to Distributed
#25139
Conversation
cc @amitmurthy |
e1a0a70
to
e3881f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@vtjnash The I am seeing Has anybody seen the
|
e3881f2
to
bc97dd4
Compare
bc97dd4
to
cd7f82c
Compare
In this case, it appears that |
The actual test failure should be at
|
cd7f82c
to
8f9ae86
Compare
ok modulo CI, I plan to merge this later today. |
The elusive 5/5 |
I was trying to fix the logic in #25119 while also optimising
myid
andnprocs
and I think it is better to fully deprecate them.
@vtjnash mentioned to me that the usage of
object_number
is most likely incorrect,but I do not understand the code well enough to attempt a fix, so I went with the minimal solution.
fixes #25077
fixes #25135
replaces #25119