Deprecate Base.Distributed #25119
Closed
Deprecate Base.Distributed #25119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
deprecation
|
cc @amitmurthy |
|
It caused the AV build to fail - #24443 (comment) - as seems to have happened here too. |
vchuravy
force-pushed
the
vc/distributed
branch
from
54ab400
to
f7cd714
Compare
|
Yeah I noticed that, just pushed a fix that passes locally for me. We do
kinda need a Deprecation warning for 0.7 ;)
…On Fri, Dec 15, 2017, 21:25 Amit Murthy ***@***.***> wrote:
It caused the AV build to fail - #24443 (comment)
<#24443 (comment)> -
as seems to have happened here too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25119 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI3akFYwX4LTmJSAqsWq2THZCXzKvNTks5tAyorgaJpZM4RECW7>
.
|
From a consistency point of view, yes. Practically, no. Because the I guess this PR now also closes #25077 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amitmurthy any reason why this was commented out in #24443?