Backports for Pkg 1.6.2 #2592
Merged
Backports for Pkg 1.6.2 #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
commented
Jun 4, 2021
src/API.jl
Outdated
| @@ -1141,7 +1144,8 @@ function precompile(ctx::Context; internal_call::Bool=false, strict::Bool=false, | |||
| end | |||
| try | |||
| ret = Logging.with_logger(Logging.NullLogger()) do | |||
| Base.compilecache(pkg, sourcepath, iob, devnull) # capture stderr, send stdout to devnull | |||
| # capture stderr, send stdout to devnull, don't skip loaded modules | |||
| Base.compilecache(pkg, sourcepath, iob, devnull, false) | |||
There was a problem hiding this comment.
@IanButterworth is this change not backportable to 1.6.2? (See test failures)
There was a problem hiding this comment.
JuliaLang/julia#40345 needs backporting to the base release branch, then CI here needs to be run against that branch
There was a problem hiding this comment.
Could JuliaLang/julia#40702 be merged early and another started to continue base backports, so that this can be tested here?
There was a problem hiding this comment.
3 tasks
KristofferC
force-pushed
the
fe/backports-release-1.6
branch
from
6d1b96e
to
7140b26
Compare
…old format (#2561) * implement manifest format with deps field * temporarily run CI on base PR * simpler convert_flat_format_manifest * default to old manifest format * remove warning about maintaining old manifest format * add unknown manifest format warning * fix * only print the major and minor part of the `manifest_format` to file * add tests for manifest.toml formats * add test for unknown manifest format warning * provide manifest file path in warning, when available * Revert "temporarily run CI on base PR" This reverts commit d4a1e14. * add support for unknown extra data in Manifest * fixes * add missing write_manifest method * fix with windows-safe regex Co-authored-by: KristofferC <[email protected]> (cherry picked from commit a3fc759) New manifest format: Fix `upgrade_manifest` and raw dict entry for nothing (#2610) (cherry picked from commit b8bea6c)
Let's not allow for false-positive results from the PkgServer. (cherry picked from commit 1e0a488)
|
This passes locally on the 1.6.2 backport branch now. |
|
Not sure how to run CI properly here now since it needs to be run against a julia branch. |
|
I'll put this commit on the 1.6 backport branch so I can run PkgEval on it. |
KristofferC
force-pushed
the
fe/backports-release-1.6
branch
from
2d1d0e9
to
d69a8a0
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.