Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unnecessary feedback #2465

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Remove some unnecessary feedback #2465

merged 1 commit into from
Mar 29, 2021

Conversation

00vareladavid
Copy link
Contributor

Fix #1629

@fredrikekre
Copy link
Member

Should the second one be kept?

@00vareladavid
Copy link
Contributor Author

@fredrikekre IMO the second one reads more like a log message, if anything.

@fredrikekre
Copy link
Member

That is the one that shows up if you do dev Example and you already happen to have an Example package in the folder, right? I think that should be displayed since you might otherwise think you get a fresh clone. The message I wanted to remove was just when you explicitly dev a path -- then I already know there is apackage there.

@00vareladavid
Copy link
Contributor Author

That is the one that shows up if you do dev Example and you already happen to have an Example package in the folder, right?

yep

you might otherwise think you get a fresh clone

yeah, this would probably be confusing if someone does not expect it

@00vareladavid 00vareladavid merged commit 97f8db8 into master Mar 29, 2021
@00vareladavid 00vareladavid deleted the dv/1629 branch March 29, 2021 21:56
fredrikekre pushed a commit that referenced this pull request Jun 4, 2021
(cherry picked from commit 97f8db8, PR#2465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncecessary "exists and looks like the correct package" printout
3 participants