Precomp: Missing fix from #2251 (Work around precompiling packages with no version entry)
#2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added two more tweaks:
|
|
Error looks like the resolve test that was added to test for specific julia_versions. |
KristofferC
pushed a commit
that referenced
this pull request
Dec 3, 2020
…th no `version` entry) (#2261) * missing change from workaround packages with no version entry #2251 * ensure one more print loop to tidy up the last task * put a bit of random offset into the spinner animations * include a package with no version number in tests (cherry picked from commit f9b60d4)
staticfloat
pushed a commit
that referenced
this pull request
Jan 6, 2021
…th no `version` entry) (#2261) * missing change from workaround packages with no version entry #2251 * ensure one more print loop to tidy up the last task * put a bit of random offset into the spinner animations * include a package with no version number in tests (cherry picked from commit f9b60d4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2251 missed one place where a missing version would break precomp.
Also, the errors weren't throwing due to coming from async tasks, so they now print via
@error