Work around precompiling packages with no version entry
#2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While experimenting with non-precompiled stdlibs, I found that a `Project.toml` that has no `version` entry set will cause `precompile()` to fail in a nasty way.
3 tasks
|
Does this fix #2146? |
|
Probably; that error looks exactly like the one I worked around. |
KristofferC
pushed a commit
that referenced
this pull request
Dec 2, 2020
IanButterworth
added a commit
to IanButterworth/Pkg.jl
that referenced
this pull request
Dec 3, 2020
KristofferC
pushed a commit
that referenced
this pull request
Dec 3, 2020
…th no `version` entry) (#2261) * missing change from workaround packages with no version entry #2251 * ensure one more print loop to tidy up the last task * put a bit of random offset into the spinner animations * include a package with no version number in tests (cherry picked from commit f9b60d4)
staticfloat
added a commit
that referenced
this pull request
Jan 6, 2021
staticfloat
pushed a commit
that referenced
this pull request
Jan 6, 2021
…th no `version` entry) (#2261) * missing change from workaround packages with no version entry #2251 * ensure one more print loop to tidy up the last task * put a bit of random offset into the spinner animations * include a package with no version number in tests (cherry picked from commit f9b60d4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting with non-precompiled stdlibs, I found that a
Project.tomlthat has noversionentry set will causeprecompile()to fail in a nasty way.
Fixes #2146