-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Random and Test to be weak deps #152
Conversation
Do we actually need these to be package extensions? |
You mean, whether we can just delete them functions instead? I think they're useful for downstream dependents, and it's more breaking to completely remove them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable middle ground between deletion and hard-dep! LGTM!
Overall, I think this is headed in the right direction. Let's consider it a breaking change. I bumped the minor version to reflect this. |
For the version change, it looks like will need to update a few packages' compat for CI to pass: |
Can we just merge this anyway? None of these downstream packages will actually be affected by this change, since their compat will prevent them from installing version 0.10 (which is indeed why this CI fails). |
Actually, let's remove the downstream tests from TS's tests, and add it to this repo's CI instead. |
67c21de
to
fe2b857
Compare
The test-related functionality is still there, but requires loading Random and Test.
fe2b857
to
434c0d8
Compare
@mkitti I believe this is ready to merge now. Should I push the button? |
Looking into the PkgEval failures here JuliaLang/julia#52841 (comment), the reason for those is that this packages say that it needs both Random and Test to load the extension, but then never end up loading Random. This used to previously work due to a bug / circumstance in that Random is in the sysimage but this behavior will be fixed with JuliaLang/julia#52841. What can be done here and the other packages that fail are:
cc @mkitti, @jakobnissen |
The test-related functionality is still there, but requires loading Random and Test.
Note that THIS MIGHT BE A BREAKING CHANGE, since users could call these functions without loading
Test
orRandom
previously.However, I think we just need to make this breaking change. There is no way around it, and as we begin moving more stuff out of the sysimage, it becomes increasingly annoying that TranscodingStreams has these needless deps.