Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dependency on Test, Random #100

Closed
StefanKarpinski opened this issue May 25, 2020 · 2 comments
Closed

remove dependency on Test, Random #100

StefanKarpinski opened this issue May 25, 2020 · 2 comments

Comments

@StefanKarpinski
Copy link
Member

There's no actual dependency of TranscodingStreams on Test or Random: it's only the testtools.jl file which uses them, which is not necessary for normal functioning, just for testing. It would be good to refactor things to eliminate this dependency and allow test code to load testtools.jl as necessary instead.
@musm
Copy link
Member

musm commented Mar 30, 2021

Yeah agreed. I don't see why that file is under src I think we should just move it to test/testtools.jl

@jakobnissen jakobnissen mentioned this issue Mar 1, 2023
Closed
@gaurav-arya gaurav-arya mentioned this issue Mar 11, 2023
Merged
@nhz2
Copy link
Member

nhz2 commented Feb 3, 2024

This was fixed by #152

@nhz2 nhz2 closed this as completed Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StefanKarpinski @musm @nhz2