Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading blink.js on loadURL #320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Loading blink.js on loadURL #320

wants to merge 2 commits into from

Commits on Jan 29, 2024

  1. Loading blink.js on loadURL 

    Addresses an issue brought up here: JuliaGizmos#150

This MR addresses the lissue by loading `blink.js` and `webio.bundle.js` whenever content is loaded using a custom URL. This was achieved by passing the URL of the websocket server to `createWindow` in main.js. This allowed the required JS files to be loaded whenever the Electron BrowserWindow does a navigation (i.e. when Julia calls `loadurl` or creates a window with :url defined).
    @bypie5
    bypie5 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    92a45b1 View commit details
    Browse the repository at this point in the history

  2. Added comments to main.js and window.jl 

    Explaining code in did-finish-load handler and in initwindowUrl
    @bypie5
    bypie5 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    4afd20f View commit details
    Browse the repository at this point in the history