Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue brought up here #150 and here #303. To summarize, those issues both mention that
Blink
was not defined when usingloadurl
.This PR addresses the issue by loading
blink.js
andwebio.bundle.js
whenever content is loaded using a custom URL. This was achieved by passing the URL of the websocket server tocreateWindow
in main.js. This allowed the required JS files to be loaded whenever the Electron BrowserWindow does a navigation (i.e. when Julia callsloadurl
or creates a window with :url defined).Also, this PR fixes a warning that would fire every time the
WebSocket
would reconnect or wheneverblink.js
was reloaded. The warning was being fired from here:Finally, I saw this
#TODO
insrc/AtomShell/window.jl
that might be relevant to these changes:Is there any way I can address that
#TODO
in this PR?