-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update quat(::Array)
to return Array{<:Quaternion}
#95
Conversation
I'm keeping this PR draft because I'm not sure whether the |
I'll remove some methods such as function Quaternion(s::Real, a::AbstractVector)
Base.depwarn("`Quaternion(s::Real, a::AbstractVector)` is deprecated and will be removed in the next breaking release (v0.7.0). Please use `Quaternion(s, a[1], a[2], a[3])` instead.", :Quaternion)
Quaternion(s, a[1], a[2], a[3])
end |
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 99.20% 99.18% -0.02%
==========================================
Files 1 1
Lines 126 123 -3
==========================================
- Hits 125 122 -3
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just 2 fixes needed.
Co-authored-by: Seth Axen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR fixes #94.
Note that this PR is considered as a breaking change.
Quaternions.jl/test/Quaternion.jl
Lines 112 to 113 in 0be4cdd