Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constructors from vector #8

Merged
merged 2 commits into from
Jan 22, 2023
Merged

Remove constructors from vector #8

merged 2 commits into from
Jan 22, 2023

Conversation

sethaxen
Copy link
Collaborator

This PR is the companion of the breaking parts of JuliaGeometry/Quaternions.jl#95.

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Merging #8 (922df68) into main (1679b7f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           71        68    -3     
=========================================
- Hits            71        68    -3     
Impacted Files Coverage Δ
src/octonion.jl 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sethaxen sethaxen requested a review from hyrodium January 22, 2023 09:30
Copy link
Collaborator

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sethaxen sethaxen merged commit b2373ef into main Jan 22, 2023
@sethaxen sethaxen deleted the rmvec branch January 22, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants