Implement more base methods #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 123 135 +12
=========================================
+ Hits 123 135 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hyrodium
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through https://github.com/JuliaLang/julia/blob/v1.8.3/base/complex.jl and implemented here for
Quaternionall overloads that are there implemented forComplex. All of these methods resulted in aMethodErrorbefore this PR, so this is a non-breaking change.The one overload I did not implement is
hash, which I would need to take some more time to understand.