-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixups to #600 #601
Small fixups to #600 #601
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #601 +/- ##
==========================================
- Coverage 97.90% 97.90% -0.01%
==========================================
Files 19 19
Lines 3249 3246 -3
==========================================
- Hits 3181 3178 -3
Misses 68 68 ☔ View full report in Codecov by Sentry. |
I think the |
Indeed, I think the case of passing in |
_small_filt_fir!
for ndims(x)>2
(size(si, 1) != 2 || (N > 1 && Base.trailingsize(si, 2) != ncols)) && | ||
(size(si, 1) != 2 || (N > 1 && size(si)[2:end] != size(x)[2:end])) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checks base on trailingsize
were more permissive, but the indexing below would then fail if the sizes didn't match, so test up here. (Also, trailingsize
was accessing a Base
internal.)
likely to lower into better code
_small_filt_fir!
forndims(x)>2
.filt
forndims(x)>2
#600 -- this doesn't change anything.