Fix multi-column filt
for ndims(x)>2
#600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
filt
(andfilt!
) support multi-column input, working column-wise. That is extremely useful for e.g. stereo audio signals. The functions accept arbitrary-dimensional input, but only work properly for at most two dimensions.Master:
While
SecondOrderSections
looks ok, running with-check-bounds=yes
reveals that it's not quite sound either:I think once upon the time, Julia supported partial linear indexing, treating the last index in a
getindex
as a linear index for all remaining dimensions. Nowadays, using aCartesianIndex
seems best for addressing the "column", so do that.