Allow different argument eltypes for filt_stepstate (fix #573)

[wheeheee]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (dcef684) to head (57560e0).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files          16       16           
  Lines        3193     3199    +6     
=======================================
+ Hits         3110     3116    +6     
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[martinholters]

A test for the isone(a[1]) && T !== V case would be good. Or remove that optimization and do the scaling unconditionally. Run-time will be dwarfed by the linear solver for computation of si anyway, I guess.

But I don't think this fixes #573 as that issue is about missing documentation which this PR doesn't add.

[wheeheee]

IIUC, it's just repeating the two-argument version for each column of an array?

[martinholters]

IIUC, it's just repeating the two-argument version for each column of an array?

I think the issue is that we only have filtfilt(coef::FilterCoefficients, x::AbstractArray) documented, not filtfilt(b, a, x).

[wheeheee]

Oh, seems filtfilt(b::AbstractVector, x::AbstractArray) is also not documented?

[wheeheee]

A test for the isone(a[1]) && T !== V case would be good.

Isn't that case covered in lines 381 to 383?
edit: Oh, sorry, that kind of test...

[martinholters]

Isn't that case covered in lines 381 to 383?
edit: Oh, sorry, that kind of test...

That needs a test where a and b have an eltype that changes under division (e.g. both are Vector{Int}), while your latest test includes an x::Vector{Int} but still b::Vector{Float64}, so those lines are still not covered.

[wheeheee]

yeah, slipped my eye. hope it's good now