Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Documentation for the Function filtfilt(b::AbstractVector, a::AbstractVector, x::AbstractArray) #573

Closed
RoyiAvital opened this issue Oct 26, 2024 · 1 comment
Closed

Missing Documentation for the Function filtfilt(b::AbstractVector, a::AbstractVector, x::AbstractArray) #573

RoyiAvital opened this issue Oct 26, 2024 · 1 comment

Comments

@RoyiAvital
Copy link

RoyiAvital commented Oct 26, 2024 •
edited
Loading

The documentation only expose filtfilt(b::AbstractVector, x::AbstractArray).
Yet filtfilt(b::AbstractVector, a::AbstractVector, x::AbstractArray) is available but not documented.

Could it be documented?

OK, Tried using it and it generates errors:

ERROR: MethodError: no method matching filt_stepstate(::Vector{Float64}, ::Vector{Int64})
@wheeheee
Copy link
Member

wheeheee commented Oct 26, 2024 •
edited
Loading

Huh. Yeah, it errors if a and b have different eltypes...probably not supposed to do that. And it also throws bounds errors on other inputs...
Well the workaround for now is to convert them to the same eltype, until a fix is merged.

wheeheee added a commit that referenced this issue Oct 27, 2024
@wheeheee
Relax filt_stepstate argument types (fix #573)
f69b966
@martinholters martinholters mentioned this issue Oct 29, 2024
Merged
wheeheee added a commit that referenced this issue Oct 29, 2024
@wheeheee
Relax filt_stepstate argument types (fix #573)
4ebf264
wheeheee added a commit to wheeheee/DSP.jl that referenced this issue Oct 30, 2024
@wheeheee
Allow different argument eltypes for filt_stepstate (fix JuliaDSP#573…
4acf844 
…) (JuliaDSP#574)

* Relax `filt_stepstate` argument types

* set maximum `pad_length` for `iir_filtfilt`

* directly use `_filt_iir!`

avoids unnecessary allocations esp. if x has >1 column

* Document `filtfilt(::AbstractVector...)`  (fixes JuliaDSP#573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RoyiAvital @wheeheee