Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch #907

Merged
merged 4 commits into from
Jul 30, 2021
Merged

Patch #907

merged 4 commits into from
Jul 30, 2021

Conversation

BGBRWR
Copy link
Contributor

@BGBRWR BGBRWR commented Jun 4, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: fixes #892, fixes #882

What is the new behavior?

No longer trying to run 'length' on null values

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@NepipenkoIgor
Copy link
Collaborator

@BGBRWR Hi . Seems like CI broken

@BGBRWR
Copy link
Contributor Author

BGBRWR commented Jul 28, 2021

@NepipenkoIgor I rebased off latest of develop and that fixed it.

@NepipenkoIgor NepipenkoIgor merged commit d5506b0 into JsDaddy:develop Jul 30, 2021
manuelmeister pushed a commit to manuelmeister/ngx-mask that referenced this pull request Sep 21, 2021
* fix(JsDaddy#892): check if input is a string

* fix(JsDaddy#882): remove mask before getting newInputValue

* fix(form-reset): update actualValue on form reset

* fix(css): no more absolute divs blocking showcase
manuelmeister pushed a commit to manuelmeister/ngx-mask that referenced this pull request Sep 22, 2021
* fix(JsDaddy#892): check if input is a string

* fix(JsDaddy#882): remove mask before getting newInputValue

* fix(form-reset): update actualValue on form reset

* fix(css): no more absolute divs blocking showcase
manuelmeister pushed a commit to manuelmeister/ngx-mask that referenced this pull request Jan 3, 2022
* fix(JsDaddy#892): check if input is a string

* fix(JsDaddy#882): remove mask before getting newInputValue

* fix(form-reset): update actualValue on form reset

* fix(css): no more absolute divs blocking showcase
manuelmeister pushed a commit to manuelmeister/ngx-mask that referenced this pull request Jan 3, 2022
* fix(JsDaddy#892): check if input is a string

* fix(JsDaddy#882): remove mask before getting newInputValue

* fix(form-reset): update actualValue on form reset

* fix(css): no more absolute divs blocking showcase
manuelmeister pushed a commit to manuelmeister/ngx-mask that referenced this pull request Jan 3, 2022
* fix(JsDaddy#892): check if input is a string

* fix(JsDaddy#882): remove mask before getting newInputValue

* fix(form-reset): update actualValue on form reset

* fix(css): no more absolute divs blocking showcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants