Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing mask programmatically marks the input as dirty #892

Closed
BGBRWR opened this issue May 5, 2021 · 2 comments · Fixed by #893 or #907
Closed

Changing mask programmatically marks the input as dirty #892

BGBRWR opened this issue May 5, 2021 · 2 comments · Fixed by #893 or #907

Comments

@BGBRWR
Copy link
Contributor

BGBRWR commented May 5, 2021

🐞 bug report

Is this a regression?

No

Description

When changing the value of mask , it marks the input as dirty. It shouldn't do that.

🔬 Minimal Reproduction

https://stackblitz.com/edit/angular-bjofqt?file=src/app/app.component.ts

🌍 Your Environment

Angular Version:



     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 11.0.2
Node: 14.16.1
OS: win32 x64

Angular: 11.0.2
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1100.2
@angular-devkit/build-angular   0.1100.2
@angular-devkit/core            11.0.2
@angular-devkit/schematics      11.0.2
@angular/cdk                    11.0.3
@schematics/angular             11.0.2
@schematics/update              0.1100.2
rxjs                            6.5.4
typescript                      4.0.5

Anything else relevant?

@williamxsp
Copy link

This is causing me some validation bugs. Thanks for the PR. Waiting for the merge

@NepipenkoIgor
Copy link
Collaborator

@BGBRWR @williamxsp Hi. Thank you for using our package. Please try v12.0.0

BGBRWR added a commit to BGBRWR/ngx-mask that referenced this issue Jun 4, 2021
@BGBRWR BGBRWR mentioned this issue Jun 4, 2021
13 tasks
BGBRWR added a commit to BGBRWR/ngx-mask that referenced this issue Jul 28, 2021
NepipenkoIgor pushed a commit that referenced this issue Jul 30, 2021
* fix(#892): check if input is a string

* fix(#882): remove mask before getting newInputValue

* fix(form-reset): update actualValue on form reset

* fix(css): no more absolute divs blocking showcase
manuelmeister pushed a commit to manuelmeister/ngx-mask that referenced this issue Sep 21, 2021
* fix(JsDaddy#892): check if input is a string

* fix(JsDaddy#882): remove mask before getting newInputValue

* fix(form-reset): update actualValue on form reset

* fix(css): no more absolute divs blocking showcase
manuelmeister pushed a commit to manuelmeister/ngx-mask that referenced this issue Sep 22, 2021
* fix(JsDaddy#892): check if input is a string

* fix(JsDaddy#882): remove mask before getting newInputValue

* fix(form-reset): update actualValue on form reset

* fix(css): no more absolute divs blocking showcase
manuelmeister pushed a commit to manuelmeister/ngx-mask that referenced this issue Jan 3, 2022
* fix(JsDaddy#892): check if input is a string

* fix(JsDaddy#882): remove mask before getting newInputValue

* fix(form-reset): update actualValue on form reset

* fix(css): no more absolute divs blocking showcase
manuelmeister pushed a commit to manuelmeister/ngx-mask that referenced this issue Jan 3, 2022
* fix(JsDaddy#892): check if input is a string

* fix(JsDaddy#882): remove mask before getting newInputValue

* fix(form-reset): update actualValue on form reset

* fix(css): no more absolute divs blocking showcase
manuelmeister pushed a commit to manuelmeister/ngx-mask that referenced this issue Jan 3, 2022
* fix(JsDaddy#892): check if input is a string

* fix(JsDaddy#882): remove mask before getting newInputValue

* fix(form-reset): update actualValue on form reset

* fix(css): no more absolute divs blocking showcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants