Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› ๏ธ Repo: Move demo to native HTML, not Angular + Bootstrap #92

Open
JoshuaKGoldberg opened this issue Jul 11, 2024 · 0 comments
Assignees
Labels
area: demo Regarding the index.html demo file accompanying this repository status: accepting prs Please, send a pull request to resolve this! ๐Ÿ™

Comments

@JoshuaKGoldberg
Copy link
Owner

Overview

Following #89: the demo/ directory uses very old, public CDN files for Angular and Bootstrap. We can get a "good enough" demo page using just the platform now.

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! ๐Ÿ™ area: demo Regarding the index.html demo file accompanying this repository labels Jul 11, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jul 11, 2024
JoshuaKGoldberg added a commit that referenced this issue Oct 15, 2024
## PR Checklist

- [x] Addresses an existing open issue: fixes #82
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/package.json-validator/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/package.json-validator/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Changes initially generated by running
[create-typescript-app](https://github.com/JoshuaKGoldberg/create-typescript-app):

```shell 
npx create-typescript-app --auto --mode migrate
```

Applies some general cleanup:

* Adds general GitHub docs, including: a code of conduct, a development
guide, and issue & PR templates
* Adds contribution recognition with [All
Contributors](https://allcontributors.org)
* Adds faster installs with [pnpm](https://pnpm.io)
* Adds formatting with [Prettier](https://prettier.io), using
[Husky](https://typicode.github.io/husky) +
[lint-staged](https://github.com/lint-staged/lint-staged) for Git commit
hooks
* Adds automated releases with
[release-it](https://github.com/release-it/release-it)
* Moves the demo app to a `demo/` directory
* Replaces JSHint with [ESLint](https://eslint.org) for linting
* Replaces QUnit with [Vitest](https://vitest.dev) for testing

Notably does not tackle these followups:

* #90
* #91
* #92
* #93

๐Ÿ’–
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: demo Regarding the index.html demo file accompanying this repository status: accepting prs Please, send a pull request to resolve this! ๐Ÿ™
Projects
None yet
Development

No branches or pull requests

1 participant