Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› οΈ Repo: Migrate to TypeScript #91

Open
JoshuaKGoldberg opened this issue Jul 11, 2024 · 2 comments Β· May be fixed by #110
Open

πŸ› οΈ Repo: Migrate to TypeScript #91

JoshuaKGoldberg opened this issue Jul 11, 2024 · 2 comments Β· May be fixed by #110
Assignees
Labels
area: tooling Managing the repository's maintenance πŸ› οΈ status: accepting prs Please, send a pull request to resolve this! πŸ™

Comments

@JoshuaKGoldberg
Copy link
Owner

Overview

Following #89: I'm a big fan of TypeScript. It'd be great to move this repo over to it. Then we can ship .d.ts types!

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! πŸ™ area: tooling Managing the repository's maintenance πŸ› οΈ labels Jul 11, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jul 11, 2024
JoshuaKGoldberg added a commit that referenced this issue Oct 15, 2024
## PR Checklist

- [x] Addresses an existing open issue: fixes #82
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/package.json-validator/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/package.json-validator/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Changes initially generated by running
[create-typescript-app](https://github.com/JoshuaKGoldberg/create-typescript-app):

```shell 
npx create-typescript-app --auto --mode migrate
```

Applies some general cleanup:

* Adds general GitHub docs, including: a code of conduct, a development
guide, and issue & PR templates
* Adds contribution recognition with [All
Contributors](https://allcontributors.org)
* Adds faster installs with [pnpm](https://pnpm.io)
* Adds formatting with [Prettier](https://prettier.io), using
[Husky](https://typicode.github.io/husky) +
[lint-staged](https://github.com/lint-staged/lint-staged) for Git commit
hooks
* Adds automated releases with
[release-it](https://github.com/release-it/release-it)
* Moves the demo app to a `demo/` directory
* Replaces JSHint with [ESLint](https://eslint.org) for linting
* Replaces QUnit with [Vitest](https://vitest.dev) for testing

Notably does not tackle these followups:

* #90
* #91
* #92
* #93

πŸ’–
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for tool.

πŸ€– Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! πŸ’™

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! πŸŽ‰

JoshuaKGoldberg added a commit that referenced this issue Oct 15, 2024
Adds @JoshuaKGoldberg as a contributor for tool.

This was requested by JoshuaKGoldberg [in this
comment](#91 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Josh Goldberg ✨ <[email protected]>
@michaelfaith michaelfaith linked a pull request Dec 30, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance πŸ› οΈ status: accepting prs Please, send a pull request to resolve this! πŸ™
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant