meta: major crates refactor / rewrite #372

Jon-Becker · 2024-03-19T13:22:01Z

No description provided.

github-actions · 2024-05-06T22:19:46Z

crates/cfg/src/interfaces/function.rs

+
+/// The [`AnalyzedFunction`] struct represents a function that has been analyzed by the decompiler.
+#[derive(Clone, Debug)]
+pub struct AnalyzedFunction {


⚠️ [clippy] _{reported by reviewdog 🐶}

warning: struct `AnalyzedFunction` is never constructed --> crates/cfg/src/interfaces/function.rs:11:12 | 11 | pub struct AnalyzedFunction { | ^^^^^^^^^^^^^^^^ | = note: `AnalyzedFunction` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

github-actions · 2024-05-06T22:19:46Z

crates/cfg/src/interfaces/function.rs

+}
+
+#[derive(Clone, Debug)]
+pub struct StorageFrame {


⚠️ [clippy] _{reported by reviewdog 🐶}

warning: struct `StorageFrame` is never constructed --> crates/cfg/src/interfaces/function.rs:59:12 | 59 | pub struct StorageFrame { | ^^^^^^^^^^^^ | = note: `StorageFrame` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

github-actions · 2024-05-06T22:19:46Z

crates/cfg/src/interfaces/function.rs

+}
+
+#[derive(Clone, Debug)]
+pub struct CalldataFrame {


⚠️ [clippy] _{reported by reviewdog 🐶}

warning: struct `CalldataFrame` is never constructed --> crates/cfg/src/interfaces/function.rs:65:12 | 65 | pub struct CalldataFrame { | ^^^^^^^^^^^^^ | = note: `CalldataFrame` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

github-actions · 2024-05-06T22:19:46Z

crates/cfg/src/core/mod.rs

+        H160::default(),
+        H160::default(),
+        0,
+        u128::max_value(),


⚠️ [clippy] _{reported by reviewdog 🐶}

warning: usage of a legacy numeric method --> crates/cfg/src/core/mod.rs:76:15 | 76 | u128::max_value(), | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 76 | u128::MAX, | ~~~

github-actions · 2024-05-06T22:19:46Z

crates/decompile/src/interfaces/function.rs

+
+/// The [`AnalyzedFunction`] struct represents a function that has been analyzed by the decompiler.
+#[derive(Clone, Debug)]
+pub struct AnalyzedFunction {


⚠️ [clippy] _{reported by reviewdog 🐶}

warning: field `entry_point` is never read --> crates/decompile/src/interfaces/function.rs:19:9 | 13 | pub struct AnalyzedFunction { | ---------------- field in this struct ... 19 | pub entry_point: u128, | ^^^^^^^^^^^ | = note: `AnalyzedFunction` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

github-actions · 2024-05-06T22:19:47Z

crates/decompile/src/utils/heuristics/events.rs

+            .join(", ");
+
+        // add the event emission to the function's logic
+        match analyzer_state.analyzer_type {


⚠️ [clippy] _{reported by reviewdog 🐶}

warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> crates/decompile/src/utils/heuristics/events.rs:35:9 | 35 | / match analyzer_state.analyzer_type { 36 | | AnalyzerType::Solidity => { 37 | | function.logic.push(format!( 38 | | "emit Event_{}({}{});{}", ... | 72 | | _ => {} 73 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 35 ~ if analyzer_state.analyzer_type == AnalyzerType::Solidity { 36 + function.logic.push(format!( 37 + "emit Event_{}({}{});{}", 38 + &event 39 + .topics 40 + .first() 41 + .unwrap_or(&U256::from(0)) 42 + .encode_hex() 43 + .replacen("0x", "", 1)[0..8], 44 + event 45 + .topics 46 + .get(1..) 47 + .map(|topics| { 48 + if !event.data.is_empty() && !topics.is_empty() { 49 + let mut solidified_topics: Vec = Vec::new(); 50 + for (i, _) in topics.iter().enumerate() { 51 + solidified_topics.push( 52 + state.last_instruction.input_operations[i + 3].solidify(), 53 + ); 54 + } 55 + format!("{}, ", solidified_topics.join(", ")) 56 + } else { 57 + let mut solidified_topics: Vec = Vec::new(); 58 + for (i, _) in topics.iter().enumerate() { 59 + solidified_topics.push( 60 + state.last_instruction.input_operations[i + 3].solidify(), 61 + ); 62 + } 63 + solidified_topics.join(", ") 64 + } 65 + }) 66 + .unwrap_or("".to_string()), 67 + data_mem_ops_solidified, 68 + if anonymous { " // anonymous event" } else { "" } 69 + )); 70 + } |

github-actions · 2024-05-06T22:19:47Z

crates/cli/src/error.rs

@@ -1,9 +1,13 @@
 #[derive(Debug, thiserror::Error)]
 pub enum Error {
-    #[error("Error: {0}")]
+    #[error("{0}")]
    Generic(String),
    #[error("IO error: {0}")]
    IOError(#[from] std::io::Error),


⚠️ [clippy] _{reported by reviewdog 🐶}

warning: variant name ends with the enum's name --> crates/cli/src/error.rs:6:5 | 6 | IOError(#[from] std::io::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names = note: `#[warn(clippy::enum_variant_names)]` on by default

github-actions · 2024-05-06T22:19:47Z

crates/cli/src/error.rs

@@ -1,9 +1,13 @@
 #[derive(Debug, thiserror::Error)]
 pub enum Error {
-    #[error("Error: {0}")]
+    #[error("{0}")]
    Generic(String),
    #[error("IO error: {0}")]
    IOError(#[from] std::io::Error),
    #[error("Serde error: {0}")]
    SerdeError(#[from] serde_json::Error),


⚠️ [clippy] _{reported by reviewdog 🐶}

warning: variant name ends with the enum's name --> crates/cli/src/error.rs:8:5 | 8 | SerdeError(#[from] serde_json::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names

github-actions · 2024-05-06T22:19:47Z

crates/cli/src/error.rs

    Generic(String),
    #[error("IO error: {0}")]
    IOError(#[from] std::io::Error),
    #[error("Serde error: {0}")]
    SerdeError(#[from] serde_json::Error),
+    #[error("Decompile error: {0}")]
+    DecompileError(#[from] heimdall_core::heimdall_decompiler::Error),


⚠️ [clippy] _{reported by reviewdog 🐶}

warning: variant name ends with the enum's name --> crates/cli/src/error.rs:10:5 | 10 | DecompileError(#[from] heimdall_core::heimdall_decompiler::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names

github-actions · 2024-05-06T22:19:47Z

crates/cli/src/error.rs

+    #[error("Decompile error: {0}")]
+    DecompileError(#[from] heimdall_core::heimdall_decompiler::Error),
+    #[error("Disassemble error: {0}")]
+    DisassembleError(#[from] heimdall_core::heimdall_disassembler::Error),


⚠️ [clippy] _{reported by reviewdog 🐶}

warning: variant name ends with the enum's name --> crates/cli/src/error.rs:12:5 | 12 | DisassembleError(#[from] heimdall_core::heimdall_disassembler::Error), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names

Jon-Becker added 8 commits March 4, 2024 15:34

fix(snapshot): fail-fast if no selectors were found

d7c9d7d

refactor: clean slate, move core mods to crates

e1fa66d

feat(disassemble): disassembler refactor

7c739d8

feat(decode): decode refactor

ef4e5f9

feat(decode): add timing to decode stage

2a26d74

feat(decode): impl TryFrom<&ResolvedFunction> for TraceFactory

25a6c5c

fix(decode): typo

39b8037

feat(inspect): inspect refactor

aa97c49

Jon-Becker changed the title ~~[WIP] meta: major crates refactor~~ [WIP] meta: major crates refactor / rewrite Mar 19, 2024

Jon-Becker marked this pull request as draft March 19, 2024 13:22

Jon-Becker added 3 commits April 7, 2024 13:27

feat(decompile): ABI generation

d6b6271

feat(decompile): ABI generation w/ events

4ba17e3

chore: make clippy happy

74e572b

Jon-Becker mentioned this pull request Apr 11, 2024

Support Ws and Ipc providers #369

Merged

Jon-Becker added 5 commits April 11, 2024 17:27

feat(decompile): abi, solidity, and yul analyzers implemented

7a41ff2

feat(decompile): Yul and Solidity source output

a82bc54

feat(decompile): source output w/ resolved errors/events

e25f544

fix(decompile): remove tainted solidity code from yul output

0bb3a0c

feat(lexer): solidity sloc tokenizer

c940f3e

Jon-Becker mentioned this pull request Apr 30, 2024

implement simplify_parentheses correctly with a tokenier #324

Closed

Jon-Becker added 3 commits May 6, 2024 16:00

feat(decompile): postprocessor implementations

95c5460

test: make tests pass

0eeb9d9

chore: merge branch main into jon-becker/snapshot-ff

26400cc

Jon-Becker marked this pull request as ready for review May 6, 2024 22:18

Jon-Becker enabled auto-merge (squash) May 6, 2024 22:18

github-actions bot reviewed May 6, 2024

View reviewed changes

Jon-Becker disabled auto-merge May 6, 2024 22:23

Jon-Becker merged commit 1278d63 into main May 6, 2024
7 checks passed

Jon-Becker changed the title ~~[WIP] meta: major crates refactor / rewrite~~ meta: major crates refactor / rewrite May 6, 2024

Jon-Becker mentioned this pull request May 7, 2024

Decompiler - Generated ABIs don't meet the Solidity ABI Spec ("bytes memory" is an invalid type) #365

Closed

2 tasks

This was referenced May 8, 2024

Decompiler - Incorrect output types #364

Closed

analyze_sol is too long and needs to be refactored into a series of smaller fu... #293

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

meta: major crates refactor / rewrite #372

meta: major crates refactor / rewrite #372

Jon-Becker commented Mar 19, 2024 •

edited

Loading

github-actions bot May 6, 2024

github-actions bot May 6, 2024

github-actions bot May 6, 2024

github-actions bot May 6, 2024

github-actions bot May 6, 2024

github-actions bot May 6, 2024

github-actions bot May 6, 2024

github-actions bot May 6, 2024

github-actions bot May 6, 2024

github-actions bot May 6, 2024

meta: major crates refactor / rewrite #372

meta: major crates refactor / rewrite #372

Conversation

Jon-Becker commented Mar 19, 2024 • edited Loading

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

Jon-Becker commented Mar 19, 2024 •

edited

Loading