-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Ws and Ipc providers #369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! once tests pass we can merge this in :)
huge thank you for contributing ❤️
T: Debug + Serialize + Send + Sync, | ||
R: DeserializeOwned + Send, | ||
{ | ||
// println!("request"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove
will get this in today :) |
ill fix the broken test case and include in #372, so this will be part of 0.8.0 |
Hey @Jon-Becker, I'm trying to use Heimdall in prod doing decompilation and I get a lot of crashes in the - esp. the more timeout I give it - in debug there are arithmetic overflows in the vm, with arithmetic checks disabled I get vector capacity errors and so on. Are you interested in those as new issues or should I wait or 0.8 and report then? Would you like them as unit tests, or just example contract addresses? Their appearance is probabilistic, some I need multiple retries to reproduce. I tried fixing them on my own, but I'm not familiar with this code enough (yet). |
if they happen on nightly, please open an issue!! you can install nightly with |
Awesome! Looks good enough to merge, i'll fix clippy in a future commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Motivation
Allow to use Ws an Ipc on par with Http RPCs.
Closes #306
Solution
Straightforward adaptation of https://www.gakonst.com/ethers-rs/providers/custom.html to include Http.
Added example tests to cover the new code.
Considerations - feedback welcome