Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, giraffate/clippy-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

[clippy] reported by reviewdog 🐶 <pre><code>warning: assigning the result of `ToOwned::to_owned()` may be inefficient --> crates/common/src/ether/evm/core/vm.rs:1500:9 | 1500 | self.calldata = calldata.to_owned(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `calldata.clone_into(&mut self.calldata)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default </code></pre> Raw Output: crates/common/src/ether/evm/core/vm.rs:1500:9:w: <pre><code>warning: assigning the result of `ToOwned::to_owned()` may be inefficient --> crates/common/src/ether/evm/core/vm.rs:1500:9 | 1500 | self.calldata = calldata.to_owned(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `calldata.clone_into(&mut self.calldata)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: match can be simplified with `.unwrap_or_default()` --> crates/common/src/ether/lexers/cleanup.rs:247:13 | 247 | / match logical_expression.get(2..logical_expression.len() - 2) { 248 | | Some(x) => x, 249 | | None => "", 250 | | }, | |_____________^ help: replace it with: `logical_expression.get(2..logical_expression.len() - 2).unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default </code></pre> Raw Output: crates/common/src/ether/lexers/cleanup.rs:247:13:w: <pre><code>warning: match can be simplified with `.unwrap_or_default()` --> crates/common/src/ether/lexers/cleanup.rs:247:13 | 247 | / match logical_expression.get(2..logical_expression.len() - 2) { 248 | | Some(x) => x, 249 | | None => "", 250 | | }, | |_____________^ help: replace it with: `logical_expression.get(2..logical_expression.len() - 2).unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: assigning the result of `ToOwned::to_owned()` may be inefficient --> crates/common/src/utils/strings.rs:272:13 | 272 | condition = condition.split(", ").collect::<Vec<&str>>()[0].to_owned(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `condition.split(", ").collect::<Vec<&str>>()[0].clone_into(&mut condition)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones </code></pre> Raw Output: crates/common/src/utils/strings.rs:272:13:w: <pre><code>warning: assigning the result of `ToOwned::to_owned()` may be inefficient --> crates/common/src/utils/strings.rs:272:13 | 272 | condition = condition.split(", ").collect::<Vec<&str>>()[0].to_owned(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `condition.split(", ").collect::<Vec<&str>>()[0].clone_into(&mut condition)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: assigning the result of `Clone::clone()` may be inefficient --> crates/decode/src/utils/abi.rs:374:17 | 374 | potential_type = types.first().expect("types is empty").clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `potential_type.clone_from(types.first().expect("types is empty"))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default </code></pre> Raw Output: crates/decode/src/utils/abi.rs:374:17:w: <pre><code>warning: assigning the result of `Clone::clone()` may be inefficient --> crates/decode/src/utils/abi.rs:374:17 | 374 | potential_type = types.first().expect("types is empty").clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `potential_type.clone_from(types.first().expect("types is empty"))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default </code></pre> __END__

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.